cleanup(common)!: remove legacy IAM classes

CHANGELOG.md

@@ -4,19 +4,6 @@
 
 <!-- Keep these sorted by estimated date -->
 
-<details>
-<summary>2022-04-01: retiring legacy IAM functions</summary>
-<br>
-
-* On 2022-04-01 (or shortly after) we are planning to remove a number of
-  IAM functions designed before [IAM conditions][iam-conditions-link]. These
-  functions do not work with IAM policies that include IAM conditions, and
-  have been marked as deprecated since before 2019-08-01, albeit in Doxygen
-  comments only. Starting with the v1.25.0 release, and depending on your
-  compiler settings, using these functions may issue a deprecation warning at
-  the call site. See [#5929] for more details.
-</details>
-
 <details>
 <summary>2022-10-01: retiring legacy Spanner admin APIs</summary>
 <br>
@@ -79,6 +66,12 @@ https://github.com/googleapis/google-cloud-cpp/issues/8234.
   * This only changes the default C++ version, we continue to test and support C++11.
   * For more details, see [#6767](https://github.com/googleapis/google-cloud-cpp/issues/6767).
 
+* The following deprecated, legacy IAM classes have been removed:
+  `google::cloud::IamPolicy`, `google::cloud::IamBinding`,
+  `google::cloud::IamBindings`. They were designed before
+  [IAM conditions][iam-conditions-link]. They did not work with IAM policies
+  that include IAM conditions. See [#5929] for more details.
+
 ### [Bigtable](https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/bigtable/README.md)
 
 **BREAKING CHANGES**

google/cloud/CMakeLists.txt

@@ -57,11 +57,6 @@ add_library(
     future.h
     future_generic.h
     future_void.h
-    iam_binding.h
-    iam_bindings.cc
-    iam_bindings.h
-    iam_policy.cc
-    iam_policy.h
     idempotency.h
     internal/absl_str_cat_quiet.h
     internal/absl_str_join_quiet.h
@@ -220,7 +215,6 @@ if (BUILD_TESTING)
         future_generic_then_test.cc
         future_void_test.cc
         future_void_then_test.cc
-        iam_bindings_test.cc
         internal/algorithm_test.cc
         internal/api_client_header_test.cc
         internal/backoff_policy_test.cc

google/cloud/bigtable/instance_admin.h

@@ -31,7 +31,6 @@
 #include "google/cloud/bigtable/resource_names.h"
 #include "google/cloud/bigtable/version.h"
 #include "google/cloud/future.h"
-#include "google/cloud/iam_policy.h"
 #include "google/cloud/project.h"
 #include "google/cloud/status_or.h"
 #include <future>
@@ -617,10 +616,6 @@ class InstanceAdmin {
   /**
    * Gets the native policy for @p instance_id.
    *
-   * This is the preferred way to `GetIamPolicy()`. This is more closely coupled
-   * to the underlying protocol, enable more actions and is more likely to
-   * tolerate future protocol changes.
-   *
    * @param instance_id the instance to query.
    * @return google::iam::v1::Policy the full IAM policy for the instance.
    *
@@ -641,10 +636,6 @@ class InstanceAdmin {
   /**
    * Sets the IAM policy for an instance.
    *
-   * This is the preferred way to the overload for `IamBindings`. This is more
-   * closely coupled to the underlying protocol, enable more actions and is more
-   * likely to tolerate future protocol changes.
-   *
    * @param instance_id which instance to set the IAM policy for.
    * @param iam_policy google::iam::v1::Policy object containing role and
    * members.
@@ -716,9 +707,6 @@ class InstanceAdmin {
   void ChangePolicies() {}
   //@}
 
-  static StatusOr<google::cloud::IamPolicy> ProtoToWrapper(
-      google::iam::v1::Policy proto);
-
   std::shared_ptr<bigtable_admin::BigtableInstanceAdminConnection> connection_;
   std::string project_id_;
   std::string project_name_;

google/cloud/bigtable/table_admin.h

@@ -28,8 +28,6 @@
 #include "google/cloud/bigtable/version.h"
 #include "google/cloud/future.h"
 #include "google/cloud/grpc_error_delegate.h"
-#include "google/cloud/iam_policy.h"
-#include "google/cloud/internal/attributes.h"
 #include "google/cloud/options.h"
 #include "google/cloud/status_or.h"
 #include "absl/types/optional.h"

google/cloud/bigtable/version.h

@@ -16,7 +16,6 @@
 #define GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_BIGTABLE_VERSION_H
 
 #include "google/cloud/bigtable/version_info.h"
-#include "google/cloud/internal/attributes.h"
 #include "google/cloud/version.h"
 #include <string>
 

google/cloud/google_cloud_cpp_common.bzl

@@ -24,9 +24,6 @@ google_cloud_cpp_common_hdrs = [
     "future.h",
     "future_generic.h",
     "future_void.h",
-    "iam_binding.h",
-    "iam_bindings.h",
-    "iam_policy.h",
     "idempotency.h",
     "internal/absl_str_cat_quiet.h",
     "internal/absl_str_join_quiet.h",
@@ -89,8 +86,6 @@ google_cloud_cpp_common_hdrs = [
 
 google_cloud_cpp_common_srcs = [
     "credentials.cc",
-    "iam_bindings.cc",
-    "iam_policy.cc",
     "internal/api_client_header.cc",
     "internal/backoff_policy.cc",
     "internal/base64_transforms.cc",

google/cloud/google_cloud_cpp_common_unit_tests.bzl

@@ -23,7 +23,6 @@ google_cloud_cpp_common_unit_tests = [
     "future_generic_then_test.cc",
     "future_void_test.cc",
     "future_void_then_test.cc",
-    "iam_bindings_test.cc",
     "internal/algorithm_test.cc",
     "internal/api_client_header_test.cc",
     "internal/backoff_policy_test.cc",