chore: update CHANGELOG for 202204 release #8684
Conversation
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
CHANGELOG.md
Outdated
|
|
||
| **Other Changes** | ||
|
|
||
| * fix(pubsublite): internal namespaces ([#8680](https://github.com/googleapis/google-cloud-cpp/pull/8680)) |
There was a problem hiding this comment.
Just omit all the comments about pubsublite
CHANGELOG.md
Outdated
|
|
||
| **Other Changes** | ||
|
|
||
| * fix(pubsublite): internal namespaces ([#8680](https://github.com/googleapis/google-cloud-cpp/pull/8680)) |
There was a problem hiding this comment.
Should we just remove everything about pubsublite? Or should it at least go under the (previously used) "Pub/Sub Lite" banner?
Codecov Report
@@ Coverage Diff @@
## main #8684 +/- ##
==========================================
- Coverage 93.42% 93.42% -0.01%
==========================================
Files 1456 1456
Lines 123820 123820
==========================================
- Hits 115682 115681 -1
- Misses 8138 8139 +1
Continue to review full report at Codecov.
|
CHANGELOG.md
Outdated
| * feat(pubsublite): single partition publisher boilerplate and `Start`/`Shutdown` implementation ([#8531](https://github.com/googleapis/google-cloud-cpp/pull/8531)) | ||
| * feat(pubsublite): service composite implementation ([#8529](https://github.com/googleapis/google-cloud-cpp/pull/8529)) | ||
| * feat(common): `g::c::future` support for coroutines ([#8532](https://github.com/googleapis/google-cloud-cpp/pull/8532)) | ||
| * fix: treat `kDeadlineExceeded` as permanent error ([#8525](https://github.com/googleapis/google-cloud-cpp/pull/8525)) |
There was a problem hiding this comment.
What might this be referring to in the "Common Libraries" section?
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @coryan, @dbolduc, and @devbww)
CHANGELOG.md, line 74 at r1 (raw file):
Previously, dbolduc (Darren Bolduc) wrote…
+1
Done.
CHANGELOG.md, line 152 at r1 (raw file):
Previously, devbww (Bradley White) wrote…
Should we just remove everything about pubsublite? Or should it at least go under the (previously used) "Pub/Sub Lite" banner?
Removed all pubsublite commit messages
CHANGELOG.md, line 161 at r1 (raw file):
Previously, devbww (Bradley White) wrote…
What might this be referring to in the "Common Libraries" section?
Moved kDeadlineExceeded change to summary section.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
enumerated services not affected |
CHANGELOG.md
Outdated
| * BigQuery | ||
| * Bigtable Admin | ||
| * IAM | ||
| * Spanner Admin |
There was a problem hiding this comment.
All of these services were affected by the PR: 7cd327f
I would put it back to the way it was one commit ago.
There was a problem hiding this comment.
Sorry about that, Scott. Perhaps, then, we should be citing two PRs?
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
This change is