Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigtable): table resource name as a class #9377

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jun 29, 2022

Fixes #9348

Plagiarized from spanner/database.h


This change is Reviewable

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jun 29, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 7e86f6c77905d36f383c4abe9d500f4793acdcfc

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #9377 (7e86f6c) into main (a5b052d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #9377   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files        1474     1477    +3     
  Lines      135379   135441   +62     
=======================================
+ Hits       128133   128193   +60     
- Misses       7246     7248    +2     
Impacted Files Coverage Δ
google/cloud/bigtable/table_resource.cc 100.00% <100.00%> (ø)
google/cloud/bigtable/table_resource.h 100.00% <100.00%> (ø)
google/cloud/bigtable/table_resource_test.cc 100.00% <100.00%> (ø)
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 97.05% <0.00%> (-2.95%) ⬇️
google/cloud/pubsub/subscriber_connection_test.cc 97.22% <0.00%> (-0.70%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5b052d...7e86f6c. Read the comment docs.

@dbolduc dbolduc marked this pull request as ready for review June 29, 2022 13:43
@dbolduc dbolduc requested a review from a team as a code owner June 29, 2022 13:43
@dbolduc dbolduc merged commit de229d5 into googleapis:main Jun 29, 2022
@dbolduc dbolduc deleted the bigtable-table-resource-class branch June 29, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offer Bigtable resource classes for the Data API.
3 participants