Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): make the RPC log even more readable #9561

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

devbww
Copy link
Contributor

@devbww devbww commented Jul 25, 2022

  • Render google.protobuf.Duration and google.protobuf.Timestamp
    fields as descriptive strings rather than as raw numbers.

This change is Reviewable

- Render google.protobuf.Duration and google.protobuf.Timestamp
  fields as descriptive strings rather than as raw numbers.
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 8c277115ca10972eb03d41ea314e404dcb2b81bc

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #9561 (363fcae) into main (71012ff) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #9561      +/-   ##
==========================================
- Coverage   94.37%   94.37%   -0.01%     
==========================================
  Files        1491     1491              
  Lines      137569   137611      +42     
==========================================
+ Hits       129829   129867      +38     
- Misses       7740     7744       +4     
Impacted Files Coverage Δ
google/cloud/internal/log_wrapper.cc 83.16% <100.00%> (+6.14%) ⬆️
google/cloud/internal/log_wrapper_test.cc 99.47% <100.00%> (+0.04%) ⬆️
.../cloud/internal/streaming_read_rpc_logging_test.cc 95.55% <100.00%> (-0.10%) ⬇️
...cloud/internal/streaming_write_rpc_logging_test.cc 100.00% <100.00%> (ø)
...le/cloud/storage/internal/curl_download_request.cc 87.62% <0.00%> (-1.01%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.98% <0.00%> (-0.68%) ⬇️
google/cloud/pubsub/subscriber_connection_test.cc 97.75% <0.00%> (-0.57%) ⬇️
google/cloud/bigtable/async_read_stream_test.cc 97.99% <0.00%> (+0.66%) ⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71012ff...363fcae. Read the comment docs.

`char const (&)[2]`, but allow for its beliefs nevertheless.
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 363fcae0750bb2ee5f3fd28e2fb4df728652287c

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@devbww devbww marked this pull request as ready for review July 25, 2022 23:02
@devbww devbww requested a review from a team as a code owner July 25, 2022 23:02
@devbww devbww merged commit 3bc1b54 into googleapis:main Jul 26, 2022
@devbww devbww deleted the custom-timestamp-printer branch July 26, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants