fix(storage): error message for resumable uploads #9855
Conversation
One of the error conditions is actually a rare, but unavoidable, problem when resuming uploads. Improve the error message to clarify this situation.
product-auto-label
bot
added
the
api: storage
|
/fyi @garlicnation |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 94.24% // Head: 94.24% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #9855 +/- ##
==========================================
- Coverage 94.24% 94.24% -0.01%
==========================================
Files 1495 1495
Lines 139834 139834
==========================================
- Hits 131785 131782 -3
- Misses 8049 8052 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| << expected_committed_size << " are expected be." | ||
| << " Most likely your application resumed an upload, and the client" | ||
| << " library queried the service to find the current persisted bytes." | ||
| << " In some cases, the service is still writing in data in the" |
There was a problem hiding this comment.
Fixed and some rewording.
| << " Then the next write reports a much higher number of bytes" | ||
| << " persisted than expected. It is not possible for the client library" | ||
| << " to recover from this situation. The application needs to resume the" | ||
| << " upload." |
There was a problem hiding this comment.
add a \n ? Or is that a bad idea in error messages?
There was a problem hiding this comment.
I want to avoid those in error messages.
| << " upload." | ||
| << " This could also be caused by multiple instances of a distributed" | ||
| << " application trying to use the same resumable upload, this is a bug" | ||
| << " in the application." |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
One of the error conditions is actually a rare, but unavoidable, problem when resuming uploads. Improve the error message to clarify this situation.
Fixes #9750
This change is