Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner: TestClient_DoForEachRow_ShouldEndSpanWithQueryError failed #10141

Closed
flaky-bot bot opened this issue May 9, 2024 · 1 comment · Fixed by #10186
Closed

spanner: TestClient_DoForEachRow_ShouldEndSpanWithQueryError failed #10141

flaky-bot bot opened this issue May 9, 2024 · 1 comment · Fixed by #10186
Assignees
@harshachinta
Labels
api: spanner Issues related to the Spanner API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented May 9, 2024

Note: #5005 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.

commit: 11e1334
buildURL: Build Status, Sponge
status: failed
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 9, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label May 9, 2024
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label May 9, 2024
@flaky-bot Flaky Bot
Copy link
Author

flaky-bot bot commented May 9, 2024

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

When run at the same commit (11e1334), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@itizir itizir mentioned this issue May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harshachinta harshachinta

Labels
api: spanner Issues related to the Spanner API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(internal/testutil): fix race when accessing trace spans
1 participant
@harshachinta