Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiler: remove x/build dependency #1344

Closed
jeanbza opened this issue Mar 5, 2019 · 3 comments
Closed

profiler: remove x/build dependency #1344

jeanbza opened this issue Mar 5, 2019 · 3 comments
Assignees
@kalyanac
Labels
api: cloudprofiler Issues related to the Cloud Profiler API. type: cleanup An internal cleanup or hygiene concern.

Comments

@jeanbza
Copy link
Member

jeanbza commented Mar 5, 2019

Relevant: golang/go#29935 (comment)

Per Alexey's comment:

It should be totally reasonable to get rid of golang.org/x/build/kubernetes dependency in cloud.google.com/go/profiler/proftest, probably replacing it with k8s.io/client-go. In fact, for now that code can just be removed as the profiler GKE tests are broken and that code needs to be updated anyway. So the immediate action is I think to remove the dependency and the code from proftest.go, then figure out how to do it proper.

In the future, when we support multiple modules within this repository, this won't be a problem.
@jeanbza jeanbza added api: cloudprofiler Issues related to the Cloud Profiler API. type: cleanup An internal cleanup or hygiene concern. labels Mar 5, 2019
@jeanbza jeanbza mentioned this issue Mar 5, 2019
Closed
@aalexand aalexand assigned kalyanac and unassigned aalexand Mar 5, 2019
@aalexand
Copy link
Contributor

aalexand commented Mar 5, 2019

Tracked with b/123400217.

@dmitshur dmitshur mentioned this issue Mar 14, 2019
Closed
@dmitshur
Copy link

This has been fixed in commit 8a3b7e3, which is included in version v0.37.3 and newer. This issue can be closed.

@odeke-em
Copy link
Contributor

Great, thank you @dmitshur for the ping!

@jeanbza jeanbza closed this as completed Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kalyanac kalyanac

Labels
api: cloudprofiler Issues related to the Cloud Profiler API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@aalexand @dmitshur @jeanbza @odeke-em @kalyanac