Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal/godocfx): different metadata for different modules #4297

Merged
merged 4 commits into from
Jun 22, 2021
Merged

Conversation

tbpg
Copy link
Contributor

@tbpg tbpg commented Jun 22, 2021

I refactored the writing of the metadata into a separate function so it can be tested directly.

@tbpg tbpg requested a review from codyoss June 22, 2021 15:44
@tbpg tbpg requested a review from a team as a code owner June 22, 2021 15:44
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 22, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbpg tbpg added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Jun 22, 2021
@tbpg tbpg merged commit 598f5b9 into master Jun 22, 2021
@tbpg tbpg deleted the metadata branch June 22, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants