Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: propagate retry config to grpc methods #6377

Closed
tritone opened this issue Jul 20, 2022 · 1 comment
Closed

storage: propagate retry config to grpc methods #6377

tritone opened this issue Jul 20, 2022 · 1 comment
Assignees
@tritone
Labels
api: storage Issues related to the Cloud Storage API. type: process A process-related concern. May include testing, release, or the like.

Comments

@tritone
Copy link
Contributor

tritone commented Jul 20, 2022

While doing #6370 I noticed that ShouldRetry is referenced directly from some methods in grpc_client.go. This means that these methods do not honor the user-configured WithErrorFunc RetryOption, if it has been passed. Filing an issue to fix this up.

cc @noahdietz
@tritone tritone added api: storage Issues related to the Cloud Storage API. type: process A process-related concern. May include testing, release, or the like. labels Jul 20, 2022
@tritone
Copy link
Contributor Author

tritone commented Apr 3, 2023

This was completed in #6754

@tritone tritone closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tritone tritone

Labels
api: storage Issues related to the Cloud Storage API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tritone