Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub/pstest): make fake handling of bq subs to be like live service #8066

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

hongalex
Copy link
Member

@hongalex hongalex commented Jun 8, 2023

When creating BQ subscriptions and when BigQueryConfig == nil, we were incorrectly converting this to the zero valued BigQueryConfig{}. This was done to mimic the behavior of PushConfig but upon further investigation, the live service does not behave like this (PushConfig is always empty valued, BigQueryConfig can be nil).

The fake is considered experimental and is safe to break.

Fixes #8044

@hongalex hongalex requested review from a team and shollyman as code owners June 8, 2023 01:33
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the Pub/Sub API. labels Jun 8, 2023
@hongalex hongalex changed the title fix!(pubsub/pstest): make fake handling of bq subs to be like live service fix(pubsub/pstest): make fake handling of bq subs to be like live service Jun 8, 2023
@hongalex hongalex merged commit 57914ec into googleapis:main Jun 8, 2023
@hongalex hongalex deleted the fix-bq-config-fake branch June 8, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pubsub/pstest: TestSubscriptionPushPull failed
2 participants