Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: TestRetryConformance failed #8185

Closed
flaky-bot bot opened this issue Jun 29, 2023 · 5 comments
Closed

storage: TestRetryConformance failed #8185

flaky-bot bot opened this issue Jun 29, 2023 · 5 comments
Assignees
Labels
api: storage Issues related to the Cloud Storage API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Jun 29, 2023

Note: #7968 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.


commit: 5cdf4e2
buildURL: Build Status, Sponge
status: failed

Test output
    retry_conformance_test.go:753: roundtrip error (may be expected): write tcp 127.0.0.1:40802->127.0.0.1:9000: write: broken pipe
        request: POST /upload/storage/v1/b/bucket-20230629-27053015565025-0060/o?alt=json&ifGenerationMatch=0&name=new-object.txt&prettyPrint=false&projection=full&uploadType=multipart HTTP/1.1
        Host: localhost:9000
        Content-Type: multipart/related; boundary=1739ef15cdc290d3e85cbd78ec609dd43fa37280611573acabf8cc11bdde
        User-Agent: google-api-go-client/0.5
        X-Goog-Api-Client: gccl-invocation-id/e6a40c82-0049-4c15-9026-ce9f0c87e26c gccl-attempt-count/1 gl-go/1.20.4 gccl/1.31.0
        X-Goog-Gcs-Idempotency-Token: e6a40c82-0049-4c15-9026-ce9f0c87e26c
        X-Retry-Test-Id: 491f3b670e3746beb3dc3072b7c4d104
retry_conformance_test.go:539: want success, got Writer.Close: Post "http://localhost:9000/upload/storage/v1/b/bucket-20230629-27053015565025-0060/o?alt=json&ifGenerationMatch=0&name=new-object.txt&prettyPrint=false&projection=full&uploadType=multipart": write tcp 127.0.0.1:40802->127.0.0.1:9000: write: broken pipe
retry_conformance_test.go:718: test not completed; unused instructions: map[storage.objects.insert:[return-reset-connection]]</pre></details>
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 29, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jun 29, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 29, 2023

Test passed for commit a3ec3cf (Build Status, Sponge)! Closing this issue.

@flaky-bot flaky-bot bot closed this as completed Jun 29, 2023
@flaky-bot flaky-bot bot reopened this Jul 5, 2023
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Jul 5, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Jul 5, 2023

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


commit: 2b99e4f
buildURL: Build Status, Sponge
status: failed

Test output
    retry_conformance_test.go:753: roundtrip error (may be expected): write tcp 127.0.0.1:52442->127.0.0.1:9000: write: broken pipe
        request: POST /upload/storage/v1/b/bucket-20230705-25544866972218-0067/o?alt=json&ifGenerationMatch=0&name=new-object.txt&prettyPrint=false&projection=full&uploadType=multipart HTTP/1.1
        Host: localhost:9000
        Content-Type: multipart/related; boundary=5e786672b7f9767979f0c35178bb97d2531eb0b6929940195b6cb38d2314
        User-Agent: google-api-go-client/0.5
        X-Goog-Api-Client: gccl-invocation-id/bcd3bf82-d1fd-431e-a275-bf11d7c1bd77 gccl-attempt-count/1 gl-go/1.17.13 gccl/1.31.0
        X-Goog-Gcs-Idempotency-Token: bcd3bf82-d1fd-431e-a275-bf11d7c1bd77
        X-Retry-Test-Id: e8272520024543658b02b809dbad7473
retry_conformance_test.go:539: want success, got Writer.Close: Post "http://localhost:9000/upload/storage/v1/b/bucket-20230705-25544866972218-0067/o?alt=json&ifGenerationMatch=0&name=new-object.txt&prettyPrint=false&projection=full&uploadType=multipart": write tcp 127.0.0.1:52442->127.0.0.1:9000: write: broken pipe
retry_conformance_test.go:718: test not completed; unused instructions: map[storage.objects.insert:[return-503]]</pre></details>

@gannett-ggreer
Copy link

Our tests using cloud.google.com/go/httpreplay with storage also fail at release v1.31.0. No amount of recording will cause the subsequent replay to succeed.

@tritone
Copy link
Contributor

tritone commented Jul 7, 2023

@gannett-ggreer I think that would be a separate issue; this is just something that flakes in our test environment sometimes. Can you file a bug?

@frankyn frankyn added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jul 14, 2023
@tritone
Copy link
Contributor

tritone commented Oct 17, 2023

This hasn't failed since July, so I'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

4 participants
@frankyn @gannett-ggreer @tritone and others