-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datastore): Adding BeginLater and transaction state #8984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
datastore/transaction.go
Outdated
// If there are no read operations on transaction, BeginTransaction RPC call is made | ||
// before rollback or commit | ||
// Currently, this setting is set but unused | ||
// TODO: Use this setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Do we usually add buganizer ids for TODOs? go/todo-style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
This PR adds following variables:
Now, these transaction options need to be saved to be used in BeginLater transactions in future PRs. So, a new field "settings" in the transaction struct has been added in this PR.