Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigtable/spanner): remove grpclb #9186

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Conversation

mohanli-ml
Copy link
Contributor

Remove attempt DirectPath gRPCLB by default in Bigtable and Spanner because:

  1. gRPCLB is being deprecated, and Bigtable and Spanner does not have any gRPCLB traffic;
  2. Attempt gRPCLB by default has known DNS amplifying issue, all: DNS request amplification with default settings #7812.

@mohanli-ml mohanli-ml requested review from a team as code owners December 18, 2023 21:46
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the Bigtable API. labels Dec 18, 2023
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Jan 18, 2024
@rahul2393
Copy link
Contributor

@mohanli-ml What's the status of this, do we still need it?

@mohanli-ml
Copy link
Contributor Author

Yes. Bigtable and Spanner has deprecated any DirectPath usage with gRPCLB, and they will only use DirectPath with Traffic Director in the future. So we should remove this option.

@bhshkh
Copy link
Contributor

bhshkh commented Feb 10, 2024

LGTM for bigtable changes

@bhshkh
Copy link
Contributor

bhshkh commented Feb 10, 2024

Ignore the conformance test failures. The tests were added in failed state.

@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Feb 17, 2024
@codyoss
Copy link
Member

codyoss commented Mar 8, 2024

@rahul2393 can we get your approval on this as well?

@bhshkh bhshkh enabled auto-merge (squash) April 16, 2024 04:13
@bhshkh bhshkh requested review from a team April 16, 2024 04:24
@bhshkh bhshkh merged commit 480f9a0 into googleapis:main Apr 16, 2024
9 of 12 checks passed
HailongWen added a commit to HailongWen/google-cloud-go that referenced this pull request Apr 17, 2024
This is to counter
googleapis#9186. Previously
`EnableDirectPath` is default to true. With the removal we need to
explicitly set it.
HailongWen added a commit to HailongWen/google-cloud-go that referenced this pull request Apr 18, 2024
This is broken by googleapis#9186.
We need to explicitly set `EnableDirectPath` to true.
rahul2393 pushed a commit that referenced this pull request Apr 20, 2024
This is broken by #9186.
We need to explicitly set `EnableDirectPath` to true.
jschaf pushed a commit to jschaf/spanner-go that referenced this pull request Oct 10, 2024
This is broken by googleapis/google-cloud-go#9186.
We need to explicitly set `EnableDirectPath` to true.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. size: xs Pull request size is extra small. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants