Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(spanner): use time.Since instead of time.Now().Sub #10096

Merged
merged 5 commits into from
May 3, 2024
Merged

chore(spanner): use time.Since instead of time.Now().Sub #10096

merged 5 commits into from
May 3, 2024

Conversation

egonelbre
Copy link
Contributor

time.Since has few optimizations to get monotonic time, also it's shorter and clearer.

@egonelbre
chore(spanner): use time.Since instead of time.Now().Sub
ab05d31 
time.Since has few optimizations to get monotonic time, also it's
shorter and clearer.
@egonelbre egonelbre requested review from a team as code owners May 3, 2024 10:04
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label May 3, 2024
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2024
@noahdietz noahdietz added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label May 3, 2024
@noahdietz noahdietz added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. and removed automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels May 3, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2024
@noahdietz noahdietz added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2024
@noahdietz noahdietz added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 63f947d into googleapis:main May 3, 2024
8 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 3, 2024
@egonelbre egonelbre deleted the timesince branch May 4, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@egonelbre @rahul2393 @noahdietz @kokoro-team