From 9f2b2bbe3707bb420c8e1aa733747efd579810a9 Mon Sep 17 00:00:00 2001
From: Solomon Duskis <sduskis@google.com>
Date: Wed, 23 Jan 2019 19:18:53 -0500
Subject: [PATCH] Removing some unused dependencies (#4385)

* Removing some unused dependencies
Also, reducing scope of auto-value to provided.

* Restoring Firestore auto-value

* Removing more instances of easymock.
---
 google-cloud-clients/google-cloud-asset/pom.xml   |  4 ----
 .../google-cloud-bigquery/pom.xml                 |  2 +-
 .../google-cloud-bigquerydatatransfer/pom.xml     | 10 ----------
 .../google-cloud-core-http/pom.xml                | 15 ---------------
 .../google-cloud-dataproc/pom.xml                 |  5 -----
 google-cloud-clients/google-cloud-dns/pom.xml     |  4 ----
 .../google-cloud-firestore/pom.xml                |  2 +-
 google-cloud-clients/google-cloud-pubsub/pom.xml  |  2 +-
 google-cloud-clients/google-cloud-redis/pom.xml   |  5 -----
 .../google-cloud-scheduler/pom.xml                |  5 -----
 google-cloud-clients/google-cloud-spanner/pom.xml |  4 ----
 google-cloud-clients/google-cloud-speech/pom.xml  |  5 -----
 google-cloud-clients/google-cloud-tasks/pom.xml   |  5 -----
 google-cloud-clients/google-cloud-trace/pom.xml   |  5 -----
 .../google-cloud-video-intelligence/pom.xml       |  5 -----
 google-cloud-clients/google-cloud-vision/pom.xml  |  5 -----
 16 files changed, 3 insertions(+), 80 deletions(-)

diff --git a/google-cloud-clients/google-cloud-asset/pom.xml b/google-cloud-clients/google-cloud-asset/pom.xml
index d2ad3762789c..91bc792cc48a 100644
--- a/google-cloud-clients/google-cloud-asset/pom.xml
+++ b/google-cloud-clients/google-cloud-asset/pom.xml
@@ -18,10 +18,6 @@
     <site.installationModule>google-cloud-asset</site.installationModule>
   </properties>
   <dependencies>
-    <dependency>
-      <groupId>${project.groupId}</groupId>
-      <artifactId>google-cloud-core</artifactId>
-    </dependency>
     <dependency>
       <groupId>${project.groupId}</groupId>
       <artifactId>google-cloud-core-grpc</artifactId>
diff --git a/google-cloud-clients/google-cloud-bigquery/pom.xml b/google-cloud-clients/google-cloud-bigquery/pom.xml
index f63d77ba7c34..147f759ad2ca 100644
--- a/google-cloud-clients/google-cloud-bigquery/pom.xml
+++ b/google-cloud-clients/google-cloud-bigquery/pom.xml
@@ -29,7 +29,7 @@
     <dependency>
       <groupId>com.google.auto.value</groupId>
       <artifactId>auto-value</artifactId>
-      <scope>compile</scope>
+      <scope>provided</scope>
     </dependency>
     <dependency>
       <groupId>${project.groupId}</groupId>
diff --git a/google-cloud-clients/google-cloud-bigquerydatatransfer/pom.xml b/google-cloud-clients/google-cloud-bigquerydatatransfer/pom.xml
index ea1616d210d3..37ffeb9ea37b 100644
--- a/google-cloud-clients/google-cloud-bigquerydatatransfer/pom.xml
+++ b/google-cloud-clients/google-cloud-bigquerydatatransfer/pom.xml
@@ -54,11 +54,6 @@
       <artifactId>junit</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>org.easymock</groupId>
-      <artifactId>easymock</artifactId>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.objenesis</groupId>
       <artifactId>objenesis</artifactId>
@@ -69,11 +64,6 @@
       <artifactId>truth</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>com.google.api.grpc</groupId>
-      <artifactId>grpc-google-iam-v1</artifactId>
-      <scope>test</scope>
-    </dependency>
     <!-- Need testing utility classes for generated gRPC clients tests -->
     <dependency>
       <groupId>com.google.api</groupId>
diff --git a/google-cloud-clients/google-cloud-core-http/pom.xml b/google-cloud-clients/google-cloud-core-http/pom.xml
index 279a57d5c0af..243238dc8422 100644
--- a/google-cloud-clients/google-cloud-core-http/pom.xml
+++ b/google-cloud-clients/google-cloud-core-http/pom.xml
@@ -35,11 +35,6 @@
       <artifactId>google-http-client</artifactId>
       <scope>compile</scope>
     </dependency>
-    <dependency>
-      <groupId>com.google.oauth-client</groupId>
-      <artifactId>google-oauth-client</artifactId>
-      <scope>compile</scope>
-    </dependency>
     <dependency>
       <groupId>com.google.guava</groupId>
       <artifactId>guava</artifactId>
@@ -54,11 +49,6 @@
       <artifactId>google-http-client-appengine</artifactId>
       <scope>compile</scope>
     </dependency>
-    <dependency>
-      <groupId>com.google.http-client</groupId>
-      <artifactId>google-http-client-jackson2</artifactId>
-      <scope>compile</scope>
-    </dependency>
     <dependency>
       <groupId>com.google.api</groupId>
       <artifactId>gax-httpjson</artifactId>
@@ -85,11 +75,6 @@
       <artifactId>truth</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>com.google.guava</groupId>
-      <artifactId>guava-testlib</artifactId>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>io.opencensus</groupId>
       <artifactId>opencensus-api</artifactId>
diff --git a/google-cloud-clients/google-cloud-dataproc/pom.xml b/google-cloud-clients/google-cloud-dataproc/pom.xml
index 63fb976deb4a..8863e7a9fc56 100644
--- a/google-cloud-clients/google-cloud-dataproc/pom.xml
+++ b/google-cloud-clients/google-cloud-dataproc/pom.xml
@@ -76,11 +76,6 @@
       <artifactId>truth</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>com.google.api.grpc</groupId>
-      <artifactId>grpc-google-iam-v1</artifactId>
-      <scope>test</scope>
-    </dependency>
     <!-- Need testing utility classes for generated gRPC clients tests -->
     <dependency>
       <groupId>com.google.api</groupId>
diff --git a/google-cloud-clients/google-cloud-dns/pom.xml b/google-cloud-clients/google-cloud-dns/pom.xml
index fd7b3d4f010d..3bb9022c7898 100644
--- a/google-cloud-clients/google-cloud-dns/pom.xml
+++ b/google-cloud-clients/google-cloud-dns/pom.xml
@@ -33,10 +33,6 @@
       <artifactId>google-api-services-dns</artifactId>
       <scope>compile</scope>
     </dependency>
-    <dependency>
-      <groupId>commons-fileupload</groupId>
-      <artifactId>commons-fileupload</artifactId>
-    </dependency>
 
     <!-- Test dependencies -->
     <dependency>
diff --git a/google-cloud-clients/google-cloud-firestore/pom.xml b/google-cloud-clients/google-cloud-firestore/pom.xml
index 6fbe2e4b4535..136b9355fd1e 100644
--- a/google-cloud-clients/google-cloud-firestore/pom.xml
+++ b/google-cloud-clients/google-cloud-firestore/pom.xml
@@ -44,7 +44,7 @@
     <dependency>
       <groupId>com.google.auto.value</groupId>
       <artifactId>auto-value</artifactId>
-      <scope>compile</scope>
+      <scope>provided</scope>
     </dependency>
     <dependency>
       <groupId>com.google.api.grpc</groupId>
diff --git a/google-cloud-clients/google-cloud-pubsub/pom.xml b/google-cloud-clients/google-cloud-pubsub/pom.xml
index df9a13324862..06b6ccc0df01 100644
--- a/google-cloud-clients/google-cloud-pubsub/pom.xml
+++ b/google-cloud-clients/google-cloud-pubsub/pom.xml
@@ -49,7 +49,7 @@
     <dependency>
       <groupId>com.google.auto.value</groupId>
       <artifactId>auto-value</artifactId>
-      <scope>compile</scope>
+      <scope>provided</scope>
     </dependency>
 
     <!-- Test dependencies -->
diff --git a/google-cloud-clients/google-cloud-redis/pom.xml b/google-cloud-clients/google-cloud-redis/pom.xml
index a722910f8c89..c46b5a8f8e0b 100644
--- a/google-cloud-clients/google-cloud-redis/pom.xml
+++ b/google-cloud-clients/google-cloud-redis/pom.xml
@@ -54,11 +54,6 @@
       <groupId>io.grpc</groupId>
       <artifactId>grpc-auth</artifactId>
     </dependency>
-    <dependency>
-      <groupId>com.google.auto.value</groupId>
-      <artifactId>auto-value</artifactId>
-      <scope>compile</scope>
-    </dependency>
 
     <!-- Test dependencies -->
     <dependency>
diff --git a/google-cloud-clients/google-cloud-scheduler/pom.xml b/google-cloud-clients/google-cloud-scheduler/pom.xml
index 346890f047c4..b02e39f57fb7 100644
--- a/google-cloud-clients/google-cloud-scheduler/pom.xml
+++ b/google-cloud-clients/google-cloud-scheduler/pom.xml
@@ -46,11 +46,6 @@
       <groupId>io.grpc</groupId>
       <artifactId>grpc-auth</artifactId>
     </dependency>
-    <dependency>
-      <groupId>com.google.auto.value</groupId>
-      <artifactId>auto-value</artifactId>
-      <scope>compile</scope>
-    </dependency>
 
     <!-- Test dependencies -->
     <dependency>
diff --git a/google-cloud-clients/google-cloud-spanner/pom.xml b/google-cloud-clients/google-cloud-spanner/pom.xml
index 8b454d51834d..24600d9b42ed 100644
--- a/google-cloud-clients/google-cloud-spanner/pom.xml
+++ b/google-cloud-clients/google-cloud-spanner/pom.xml
@@ -129,10 +129,6 @@
       <groupId>com.google.code.findbugs</groupId>
       <artifactId>jsr305</artifactId>
     </dependency>
-    <dependency>
-      <groupId>joda-time</groupId>
-      <artifactId>joda-time</artifactId>
-    </dependency>
 
     <!-- Test dependencies -->
     <dependency>
diff --git a/google-cloud-clients/google-cloud-speech/pom.xml b/google-cloud-clients/google-cloud-speech/pom.xml
index d267cac8419e..2a5684401bbe 100644
--- a/google-cloud-clients/google-cloud-speech/pom.xml
+++ b/google-cloud-clients/google-cloud-speech/pom.xml
@@ -57,11 +57,6 @@
       <artifactId>junit</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>org.easymock</groupId>
-      <artifactId>easymock</artifactId>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.objenesis</groupId>
       <artifactId>objenesis</artifactId>
diff --git a/google-cloud-clients/google-cloud-tasks/pom.xml b/google-cloud-clients/google-cloud-tasks/pom.xml
index d385abdf536b..af7e1c50e645 100644
--- a/google-cloud-clients/google-cloud-tasks/pom.xml
+++ b/google-cloud-clients/google-cloud-tasks/pom.xml
@@ -53,11 +53,6 @@
       <artifactId>junit</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>org.easymock</groupId>
-      <artifactId>easymock</artifactId>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.objenesis</groupId>
       <artifactId>objenesis</artifactId>
diff --git a/google-cloud-clients/google-cloud-trace/pom.xml b/google-cloud-clients/google-cloud-trace/pom.xml
index e574987efc75..e80f2aa3eaef 100644
--- a/google-cloud-clients/google-cloud-trace/pom.xml
+++ b/google-cloud-clients/google-cloud-trace/pom.xml
@@ -53,11 +53,6 @@
       <artifactId>junit</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>org.easymock</groupId>
-      <artifactId>easymock</artifactId>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.objenesis</groupId>
       <artifactId>objenesis</artifactId>
diff --git a/google-cloud-clients/google-cloud-video-intelligence/pom.xml b/google-cloud-clients/google-cloud-video-intelligence/pom.xml
index fcecc02213d5..d95fec46f7dc 100644
--- a/google-cloud-clients/google-cloud-video-intelligence/pom.xml
+++ b/google-cloud-clients/google-cloud-video-intelligence/pom.xml
@@ -66,11 +66,6 @@
       <artifactId>junit</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>org.easymock</groupId>
-      <artifactId>easymock</artifactId>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.objenesis</groupId>
       <artifactId>objenesis</artifactId>
diff --git a/google-cloud-clients/google-cloud-vision/pom.xml b/google-cloud-clients/google-cloud-vision/pom.xml
index ab995db5e7b4..9f3775056755 100644
--- a/google-cloud-clients/google-cloud-vision/pom.xml
+++ b/google-cloud-clients/google-cloud-vision/pom.xml
@@ -61,11 +61,6 @@
       <artifactId>junit</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>org.easymock</groupId>
-      <artifactId>easymock</artifactId>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.objenesis</groupId>
       <artifactId>objenesis</artifactId>