Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Pub/Sub management methods, add javadoc and tests #1015

Merged
merged 2 commits into from
May 22, 2016
Merged

Implement Pub/Sub management methods, add javadoc and tests #1015

merged 2 commits into from
May 22, 2016

Conversation

mziccard
Copy link
Contributor

This PR implements the following functionality:

  • create topic
  • get topic
  • list topics
  • delete topic
  • create subscription
  • get subscription
  • list subscriptions
  • delete subscription
  • modify push config

This also fixes #987.

System tests are implemented in a base class (BaseSystemTest) so that running them in the emulator as well as the remote service is as easy as extending it. Now only tests against emulator are added (LocalSystemTest class).

/cc @lesv @jgeewax

@mziccard mziccard added the api: pubsub Issues related to the Pub/Sub API. label May 17, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 17, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 84.251% when pulling 6ddf85e on mziccard:pubsub-management into 2656eb9 on GoogleCloudPlatform:pubsub-alpha.

mziccard
mziccard reviewed May 17, 2016
View reviewed changes
gcloud-java-pubsub/src/test/java/com/google/cloud/pubsub/PubSubImplTest.java
import java.util.concurrent.ExecutionException;
import java.util.concurrent.Future;

public class PubSubImplTest {

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 84.251% when pulling 2034c58 on mziccard:pubsub-management into 2656eb9 on GoogleCloudPlatform:pubsub-alpha.

@mziccard mziccard merged commit fe4c90c into googleapis:pubsub-alpha May 22, 2016
aozarov
aozarov reviewed May 23, 2016
View reviewed changes
gcloud-java-pubsub/src/main/java/com/google/cloud/pubsub/PubSubImpl.java
@@ -16,22 +16,45 @@

package com.google.cloud.pubsub;

import static com.google.api.client.util.Preconditions.checkArgument;

This comment was marked as spam.

Sign in to view

@aozarov
Copy link
Contributor

aozarov commented May 23, 2016

@jgeewax @lesv @mziccard There are way too many PRs being merged without review.

@mziccard mziccard mentioned this pull request May 24, 2016
Closed
@lesv
Copy link
Contributor

lesv commented May 27, 2016

I'm back from vacation. I'll be reviewing things daily, but I'm still a day or two behind - I'll start doing detailed reviews on Saturday.

@lesv
Copy link
Contributor

lesv commented May 27, 2016

@jgeewax @aozarov I need to read a bunch of code before my reviews can be deep. i'm going to start that on Saturday. (in the meantime @mziccard if something is superficial, just add that word to this comments and I'll review quickly.

mziccard added a commit to mziccard/gcloud-java that referenced this pull request Jun 27, 2016
@mziccard
Implement Pub/Sub management methods, add javadoc and tests (googleap…
a9e3873 
…is#1015)
github-actions bot pushed a commit that referenced this pull request Aug 22, 2022
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-storage to v2.1…
7a2fcb0 
…1.3 (#1015)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-storage](https://github.com/googleapis/java-storage) | `2.11.2` -> `2.11.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.11.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.11.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.11.3/compatibility-slim/2.11.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.11.3/confidence-slim/2.11.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-storage</summary>

### [`v2.11.3`](https://github.com/googleapis/java-storage/blob/HEAD/CHANGELOG.md#&#8203;2113-httpsgithubcomgoogleapisjava-storagecomparev2112v2113-2022-08-08)

[Compare Source](https://github.com/googleapis/java-storage/compare/v2.11.2...v2.11.3)

##### Dependencies

-   update dependency com.google.cloud:google-cloud-pubsub to v1.120.11 ([#&#8203;1551](https://github.com/googleapis/java-storage/issues/1551)) ([0fc2d33](https://github.com/googleapis/java-storage/commit/0fc2d336c536deb3efe95e770d47fc898af12323))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-aiplatform).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTAuNCIsInVwZGF0ZWRJblZlciI6IjMyLjE1NC40In0=-->
This was referenced Aug 24, 2022
Closed
Closed
github-actions bot pushed a commit that referenced this pull request Sep 19, 2022
@release-please
chore(main): release 3.3.0 (#1025)
9bd4e09 
🤖 I have created a release *beep* *boop*
---


## [3.3.0](googleapis/java-aiplatform@v3.2.0...v3.3.0) (2022-09-15)


### Features

* add input_artifacts to PipelineJob.runtime_config in aiplatform v1 pipeline_job ([ff7a4ab](googleapis/java-aiplatform@ff7a4ab))
* Add model_monitoring_stats_anomalies,model_monitoring_status to BatchPredictionJob in aiplatform v1beta1 batch_prediction_job.proto ([#1041](googleapis/java-aiplatform#1041)) ([fe03c60](googleapis/java-aiplatform@fe03c60))
* Add read_mask to ListPipelineJobsRequest in aiplatform v1 pipeline_service ([#1032](googleapis/java-aiplatform#1032)) ([ff7a4ab](googleapis/java-aiplatform@ff7a4ab))
* Add UpsertDatapoints and RemoveDatapoints rpcs to IndexService in aiplatform v1 index_service.proto ([#1030](googleapis/java-aiplatform#1030)) ([4114021](googleapis/java-aiplatform@4114021))
* add UpsertDatapoints and RemoveDatapoints rpcs to IndexService in aiplatform v1beta1 index_service.proto ([4114021](googleapis/java-aiplatform@4114021))
* Add WriteFeatureValues in aiplatform v1beta1 featurestore_online_service.proto ([#1022](googleapis/java-aiplatform#1022)) ([267827e](googleapis/java-aiplatform@267827e))


### Dependencies

* Update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.18.0 ([#1021](googleapis/java-aiplatform#1021)) ([c3d34a0](googleapis/java-aiplatform@c3d34a0))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.5 ([#1016](googleapis/java-aiplatform#1016)) ([cc0af7b](googleapis/java-aiplatform@cc0af7b))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.6 ([#1026](googleapis/java-aiplatform#1026)) ([6ed66cc](googleapis/java-aiplatform@6ed66cc))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 ([#1031](googleapis/java-aiplatform#1031)) ([5adefd4](googleapis/java-aiplatform@5adefd4))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 ([#1040](googleapis/java-aiplatform#1040)) ([b6c1b20](googleapis/java-aiplatform@b6c1b20))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 ([#1044](googleapis/java-aiplatform#1044)) ([5ce52e5](googleapis/java-aiplatform@5ce52e5))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#1043](googleapis/java-aiplatform#1043)) ([40eae55](googleapis/java-aiplatform@40eae55))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#1045](googleapis/java-aiplatform#1045)) ([0f66302](googleapis/java-aiplatform@0f66302))
* Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#1015](googleapis/java-aiplatform#1015)) ([7a2fcb0](googleapis/java-aiplatform@7a2fcb0))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Oct 24, 2022
@gcf-owl-bot
chore(deps): Update gapic-generator-java to 2.10.1 and gax-java to 2.…
b0a8c54 
…19.4 (#1015)

* chore(deps): Update gapic-generator-java to 2.10.1 and gax-java to 2.19.4

PiperOrigin-RevId: 482898738

Source-Link: googleapis/googleapis@8886bac

Source-Link: googleapis/googleapis-gen@0edcbf1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGVkY2JmMWY4MWNhNmM1ZDFjMzg0NmZiNmJjZmI1ZDNhMGNmNDNiZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
suztomo pushed a commit that referenced this pull request Feb 1, 2023
@release-please
chore(main): release 2.8.27 (#1015)
629becd 
🤖 I have created a release *beep* *boop*
---


## [2.8.27](https://github.com/googleapis/java-core/compare/v2.8.26...v2.8.27) (2022-11-07)


### Dependencies

* Update dependency com.google.api:gax-bom to v2.19.5 ([#1014](https://github.com/googleapis/java-core/issues/1014)) ([c2e6f3e](https://github.com/googleapis/java-core/commit/c2e6f3ec03b20210104e307e8c23392d9de6d5f7))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mziccard @coveralls @aozarov @lesv @googlebot