Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Many APIs] Add an API method for reordering firewall policies #10378

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Feb 14, 2024

  • Regenerate this pull request now.

PiperOrigin-RevId: 607015517

Source-Link: googleapis/googleapis@c43e216

Source-Link: https://github.com/googleapis/googleapis-gen/commit/71c27adc96b0c80093b4a413815bd93943196bb2
Copy-Tag: eyJwIjoiamF2YS1jbG91ZGJ1aWxkLy5Pd2xCb3QueWFtbCIsImgiOiI3MWMyN2FkYzk2YjBjODAwOTNiNGE0MTM4MTViZDkzOTQzMTk2YmIyIn0=
Copy-Tag: eyJwIjoiamF2YS1jbG91ZHF1b3Rhcy8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1jbG91ZHN1cHBvcnQvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1jb21wdXRlLy5Pd2xCb3QueWFtbCIsImgiOiI3MWMyN2FkYzk2YjBjODAwOTNiNGE0MTM4MTViZDkzOTQzMTk2YmIyIn0=
Copy-Tag: eyJwIjoiamF2YS1jb250YWluZXIvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1jb250YWluZXJhbmFseXNpcy8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1kYXRhZmxvdy8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1kYXRhcHJvYy1tZXRhc3RvcmUvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1kZWJ1Z2dlci1jbGllbnQvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1kaWFsb2dmbG93LWN4Ly5Pd2xCb3QueWFtbCIsImgiOiI3MWMyN2FkYzk2YjBjODAwOTNiNGE0MTM4MTViZDkzOTQzMTk2YmIyIn0=
Copy-Tag: eyJwIjoiamF2YS1kaWFsb2dmbG93Ly5Pd2xCb3QueWFtbCIsImgiOiI3MWMyN2FkYzk2YjBjODAwOTNiNGE0MTM4MTViZDkzOTQzMTk2YmIyIn0=
Copy-Tag: eyJwIjoiamF2YS1kaXNjb3ZlcnllbmdpbmUvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1kaXN0cmlidXRlZGNsb3VkZWRnZS8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1kbHAvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1kb2N1bWVudC1haS8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1kb21haW5zLy5Pd2xCb3QueWFtbCIsImgiOiI3MWMyN2FkYzk2YjBjODAwOTNiNGE0MTM4MTViZDkzOTQzMTk2YmIyIn0=
Copy-Tag: eyJwIjoiamF2YS1lZGdlbmV0d29yay8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1lbnRlcnByaXNla25vd2xlZGdlZ3JhcGgvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1lcnJvcnJlcG9ydGluZy8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1lc3NlbnRpYWwtY29udGFjdHMvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 14, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 14, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 14, 2024
@alicejli
Copy link
Contributor

alicejli commented Feb 16, 2024

Closing this as something went awry here. The PR never made it out of Draft mode because Owlbot post-processor was not able to run successfully on this PR (likely because it was too many files).

Owlbot should regenerate what it needs in a new PR.

@alicejli alicejli closed this Feb 16, 2024
@alicejli alicejli reopened this Feb 16, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 16, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2024
Copy link
Contributor Author

gcf-owl-bot bot commented Feb 16, 2024

Owl bot is regenerating pull request 10378...
Build name: YjRlZTMzMzMtNmUzNy00MjVjLTkyODQtNmE3ZGQ3NWJlOGYx

@alicejli
Copy link
Contributor

I think my hypothesis was incorrect - #10382 is failing unit tests because I suspect it relies on updates made in this PR. Reopening this.

PiperOrigin-RevId: 607015517

Source-Link: googleapis/googleapis@c43e216

Source-Link: https://github.com/googleapis/googleapis-gen/commit/71c27adc96b0c80093b4a413815bd93943196bb2
Copy-Tag: eyJwIjoiamF2YS1jbG91ZGJ1aWxkLy5Pd2xCb3QueWFtbCIsImgiOiI3MWMyN2FkYzk2YjBjODAwOTNiNGE0MTM4MTViZDkzOTQzMTk2YmIyIn0=
Copy-Tag: eyJwIjoiamF2YS1jbG91ZHF1b3Rhcy8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1jbG91ZHN1cHBvcnQvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1jb21wdXRlLy5Pd2xCb3QueWFtbCIsImgiOiI3MWMyN2FkYzk2YjBjODAwOTNiNGE0MTM4MTViZDkzOTQzMTk2YmIyIn0=
Copy-Tag: eyJwIjoiamF2YS1jb250YWluZXIvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1jb250YWluZXJhbmFseXNpcy8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1kYXRhZmxvdy8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1kYXRhcHJvYy1tZXRhc3RvcmUvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1kZWJ1Z2dlci1jbGllbnQvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1kaWFsb2dmbG93LWN4Ly5Pd2xCb3QueWFtbCIsImgiOiI3MWMyN2FkYzk2YjBjODAwOTNiNGE0MTM4MTViZDkzOTQzMTk2YmIyIn0=
Copy-Tag: eyJwIjoiamF2YS1kaWFsb2dmbG93Ly5Pd2xCb3QueWFtbCIsImgiOiI3MWMyN2FkYzk2YjBjODAwOTNiNGE0MTM4MTViZDkzOTQzMTk2YmIyIn0=
Copy-Tag: eyJwIjoiamF2YS1kaXNjb3ZlcnllbmdpbmUvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1kaXN0cmlidXRlZGNsb3VkZWRnZS8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1kbHAvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1kb2N1bWVudC1haS8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1kb21haW5zLy5Pd2xCb3QueWFtbCIsImgiOiI3MWMyN2FkYzk2YjBjODAwOTNiNGE0MTM4MTViZDkzOTQzMTk2YmIyIn0=
Copy-Tag: eyJwIjoiamF2YS1lZGdlbmV0d29yay8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1lbnRlcnByaXNla25vd2xlZGdlZ3JhcGgvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
Copy-Tag: eyJwIjoiamF2YS1lcnJvcnJlcG9ydGluZy8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
Copy-Tag: eyJwIjoiamF2YS1lc3NlbnRpYWwtY29udGFjdHMvLk93bEJvdC55YW1sIiwiaCI6IjcxYzI3YWRjOTZiMGM4MDA5M2I0YTQxMzgxNWJkOTM5NDMxOTZiYjIifQ==
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-253a7b4fb4e87225642b branch from e89d50d to 7cc0c9b Compare February 16, 2024 16:10
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2024
@alicejli alicejli added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2024
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review February 16, 2024 17:40
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner February 16, 2024 17:40
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 16, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2024
@alicejli
Copy link
Contributor

I think my hypothesis was incorrect - #10382 is failing unit tests because I suspect it relies on updates made in this PR. Reopening this.

I think that was incorrect as well. I think the unit tests were failing because of an outdated owlbot.lock image. Once #10304 was merged, the unit tests here passed.

@alicejli alicejli enabled auto-merge (squash) February 16, 2024 18:16
@alicejli alicejli merged commit d90ecc7 into main Feb 16, 2024
30 checks passed
@alicejli alicejli deleted the owl-bot-copy-253a7b4fb4e87225642b branch February 16, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants