feat: remove GKEHubv1alpha2 #10415
Merged
feat: remove GKEHubv1alpha2 #10415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alicejli
added
the
do not merge
|
Adding |
JoeWang1127
reviewed
Mar 4, 2024
java-gkehub/.OwlBot.yaml
Outdated
| @@ -28,13 +28,9 @@ deep-copy-regex: | |||
| dest: "/owl-bot-staging/java-gkehub/v1beta/proto-google-cloud-gkehub-v1beta/src" | |||
| - source: "/google/cloud/gkehub/v1beta1/.*-java/proto-google-.*/src/main/java/com/google/cloud/gkehub" | |||
| dest: "/owl-bot-staging/java-gkehub/v1beta1/proto-google-cloud-gkehub-v1beta1/src/main/java/com/google/cloud/gkehub" | |||
There was a problem hiding this comment.
Suggested change
| dest: "/owl-bot-staging/java-gkehub/v1beta1/proto-google-cloud-gkehub-v1beta1/src/main/java/com/google/cloud/gkehub" | |
| - source: "/google/cloud/gkehub/(v.*)/.*-java/proto-google-.*/src" | |
| dest: "/owl-bot-staging/java-gkehub/$1/proto-google-cloud-alloydb-$1/src" |
There's no v1alpha2 in googleapis-gen. Could you change these two lines without specifying the version?
zhumin8
removed
the
do not merge
zhumin8
added a commit
that referenced
this pull request
Mar 6, 2024
followup on #10415. existing-version-check on release branch reported snapshot versions: com.google.api.grpc:grpc-google-cloud-gkehub-v1alpha2:0.43.0-SNAPSHOT: com.google.api.grpc:proto-google-cloud-gkehub-v1alpha2:0.43.0-SNAPSHOT GKEHubv1alpha2 modules are removed, but owl-bot is not able to cleanup these pom files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GKEHubv1alpha2 protos are removed. This PR removes those modules and updates the
.OwlBot.yamlfile to ensure they are not copied over from googleapis-gen in the future.