Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery storage settings don't propagate the user-agent header #4737

Closed
kmjung opened this issue Mar 25, 2019 · 0 comments
Closed

BigQuery storage settings don't propagate the user-agent header #4737

kmjung opened this issue Mar 25, 2019 · 0 comments
Assignees
Labels
api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@kmjung
Copy link

kmjung commented Mar 25, 2019

This doesn't work:

      BigQueryStorageSettings settings =
          BigQueryStorageSettings.newBuilder()
              .setHeaderProvider(USER_AGENT_HEADER_PROVIDER)
              .build();

This does:

      BigQueryStorageSettings settings =
          BigQueryStorageSettings.newBuilder()
              .setTransportChannelProvider(
                  BigQueryStorageSettings.defaultGrpcTransportProviderBuilder()
                      .setHeaderProvider(USER_AGENT_HEADER_PROVIDER)
                      .build())
              .build();

This seems wrong.

@sduskis sduskis added type: question Request for information or clarification. Not an issue. api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: question Request for information or clarification. Not an issue. labels Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants