Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [apikeys] new module for apikeys #8550

Merged
merged 2 commits into from
Oct 10, 2022
Merged

feat: [apikeys] new module for apikeys #8550

merged 2 commits into from
Oct 10, 2022

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Oct 7, 2022

  • feat: initial generation of apikeys
  • build: add the apikeys module to monorepo

@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 7, 2022
@suztomo
Copy link
Member Author

suztomo commented Oct 7, 2022

GraalVM tests failed. It seems irrelevant:

[ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 5.827 s <<< FAILURE! - in com.google.cloud.compute.v1.integration.ITAddressesTest
[ERROR] testList  Time elapsed: 2.337 s  <<< FAILURE!
java.lang.AssertionError: Insert operation failed.
	at org.junit.Assert.fail(Assert.java:89)
	at com.google.cloud.compute.v1.integration.ITAddressesTest.insertAddress(ITAddressesTest.java:126)
	at com.google.cloud.compute.v1.integration.ITAddressesTest.insertAddress(ITAddressesTest.java:116)
	at com.google.cloud.compute.v1.integration.ITAddressesTest.testList(ITAddressesTest.java:75)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)

@lqiu96 lqiu96 self-requested a review October 7, 2022 16:20
@lqiu96 lqiu96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2022
@lqiu96 lqiu96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2022
@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label Oct 7, 2022
lqiu96
lqiu96 reviewed Oct 7, 2022
View reviewed changes
java-apikeys/.OwlBot.yaml Outdated
Comment on lines 17 to 19
- "/grpc-google-.*/src"
- "/proto-google-.*/src"
- "/google-.*/src"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? On second look at this, shouldn't this be /java-apikeys/...

@lqiu96 lqiu96 removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 7, 2022
@suztomo suztomo closed this Oct 7, 2022
@suztomo suztomo reopened this Oct 10, 2022
@suztomo suztomo force-pushed the new_module_java-apikeys branch from 0d6669d to 9fcbf31 Compare October 10, 2022 13:54
suztomo
suztomo commented Oct 10, 2022
View reviewed changes
java-apikeys/.OwlBot.yaml
Comment on lines +16 to +23
deep-remove-regex:
- "/java-apikeys/grpc-google-.*/src"
- "/java-apikeys/proto-google-.*/src"
- "/java-apikeys/google-.*/src"

deep-preserve-regex:
- "/java-apikeys/google-.*/src/test/java/com/google/cloud/.*/v.*/it/IT.*Test.java"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lqiu96 Module name added to the entries.

@suztomo suztomo added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 10, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 10, 2022
@suztomo suztomo merged commit 00a6d87 into googleapis:main Oct 10, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 10, 2022
@suztomo suztomo deleted the new_module_java-apikeys branch October 10, 2022 14:38
This was referenced Oct 10, 2022
Closed
Closed
Merged
@release-please release-please bot mentioned this pull request Nov 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

@meltsufin meltsufin meltsufin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suztomo @lqiu96 @meltsufin @yoshi-kokoro