Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [servicemanagement] Add a proto message to describe the resource_type and resource_permission for an API method #9687

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jul 25, 2023

  • Regenerate this pull request now.

PiperOrigin-RevId: 550688034

Source-Link: googleapis/googleapis@52a738b

Source-Link: https://github.com/googleapis/googleapis-gen/commit/a4242e487cb71adc5cbc5c356348b77ff477f03a
Copy-Tag: eyJwIjoiamF2YS1zZXJ2aWNlLW1hbmFnZW1lbnQvLk93bEJvdC55YW1sIiwiaCI6ImE0MjQyZTQ4N2NiNzFhZGM1Y2JjNWMzNTYzNDhiNzdmZjQ3N2YwM2EifQ==

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2023
@snippet-bot
Copy link

snippet-bot bot commented Jul 25, 2023

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2023
@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Aug 2, 2023

Owl bot is regenerating pull request 9687...
Build name: YmIzZDJkMTAtNzZhMi00YTAzLTk2MmUtNmNmYWM0OGRhODZh

@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-java-service-management branch from b9f74d9 to 9459324 Compare August 2, 2023 18:48
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 2, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 2, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 2, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 2, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 2, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 2, 2023
@JoeWang1127
Copy link
Contributor

Unit test failed:

2023-08-02T19:20:02.8366411Z 19:20:02:834 [ERROR] com.google.cloud.api.servicemanagement.v1.ServiceManagerClientHttpJsonTest.getIamPolicyTest  Time elapsed: 0.026 s  <<< ERROR!
2023-08-02T19:20:02.8385944Z com.google.api.gax.rpc.NotFoundException: 
2023-08-02T19:20:02.8386737Z com.google.api.client.http.HttpResponseException: 404
2023-08-02T19:20:02.8388119Z POST https://servicemanagement.googleapis.com:443/v1/GetIamPolicyRequest-1527610370:getIamPolicy?$alt=json;enum-encoding%3Dint
2023-08-02T19:20:02.8388880Z Method not found for path 'https:///v1/GetIamPolicyRequest-1527610370:getIamPolicy'
2023-08-02T19:20:02.8389448Z 	at com.google.api.gax.rpc.ApiExceptionFactory.createException(ApiExceptionFactory.java:90)
2023-08-02T19:20:02.8390089Z 	at com.google.api.gax.rpc.ApiExceptionFactory.createException(ApiExceptionFactory.java:41)
2023-08-02T19:20:02.8390852Z 	at com.google.api.gax.httpjson.HttpJsonApiExceptionFactory.createApiException(HttpJsonApiExceptionFactory.java:75)
2023-08-02T19:20:02.8391650Z 	at com.google.api.gax.httpjson.HttpJsonApiExceptionFactory.create(HttpJsonApiExceptionFactory.java:54)
2023-08-02T19:20:02.8392432Z 	at com.google.api.gax.httpjson.HttpJsonExceptionCallable$ExceptionTransformingFuture.onFailure(HttpJsonExceptionCallable.java:97)
2023-08-02T19:20:02.8393145Z 	at com.google.api.core.ApiFutures$1.onFailure(ApiFutures.java:84)
2023-08-02T19:20:02.8393609Z 	at com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1127)

@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Aug 2, 2023

Owl bot is regenerating pull request 9687...
Build name: ZDE2ODc0N2UtYTMxOC00MTc0LTk5M2UtNWRhMjQ5ZWViNzIy

…ce_permission` for an API method

PiperOrigin-RevId: 550688034

Source-Link: googleapis/googleapis@52a738b

Source-Link: https://github.com/googleapis/googleapis-gen/commit/a4242e487cb71adc5cbc5c356348b77ff477f03a
Copy-Tag: eyJwIjoiamF2YS1zZXJ2aWNlLW1hbmFnZW1lbnQvLk93bEJvdC55YW1sIiwiaCI6ImE0MjQyZTQ4N2NiNzFhZGM1Y2JjNWMzNTYzNDhiNzdmZjQ3N2YwM2EifQ==
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-java-service-management branch from d32b102 to aa3c8d0 Compare August 2, 2023 20:37
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 2, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 2, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 2, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 2, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 2, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 2, 2023
@lqiu96
Copy link
Contributor

lqiu96 commented Aug 2, 2023

FYI @JoeWang1127, this issue has been logged here: googleapis/sdk-platform-java#1839

We've decided to ignore these test for now. For some reason the owlbot ignore here:

- "/java-service-management/google-cloud-service-management/src/test/java/com/google/cloud/api/servicemanagement/v1/ServiceManagerClientHttpJsonTest.java"
isn't working properly

I'll need to take another look.

@JoeWang1127
Copy link
Contributor

@lqiu96 I think this line is to reserve the file, not to ignore it.

- "/java-service-management/google-cloud-service-management/src/test/java/com/google/cloud/api/servicemanagement/v1/ServiceManagerClientHttpJsonTest.java"

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 3, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 3, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 3, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 3, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2023
@JoeWang1127 JoeWang1127 requested a review from lqiu96 August 3, 2023 17:49
@JoeWang1127 JoeWang1127 merged commit 2c7313c into main Aug 3, 2023
@JoeWang1127 JoeWang1127 deleted the owl-bot-copy-java-service-management branch August 3, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants