Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc, protobuf, datastore and gax dependencies, regenerate SPI classes #1273

Merged
merged 7 commits into from
Sep 28, 2016

Conversation

garrettjonesgoogle
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle commented Sep 21, 2016

  • Updating grpc to 1.0.1 and protobuf to 3.0.0
  • Converting PageAccessor to PagedListResponse
  • Adding auto-generated tests for logging

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2016
@mziccard
Copy link
Contributor

@garrettjonesgoogle I finally merged monitoring, does this affect this PR?

Build is failing, it seems that gax 0.0.18 is not out yet.

* Updating grpc to 1.0.1 and protobuf to 3.0.0
* Converting PageAccessor to PagedListResponse
* Adding auto-generated tests for logging
@garrettjonesgoogle
Copy link
Member Author

Yes, monitoring affects this PR. I will update it. gax 0.0.18 is released now so the next build should succeed.

@garrettjonesgoogle
Copy link
Member Author

Updated monitoring, PTAL

@garrettjonesgoogle
Copy link
Member Author

It turns out that datastore depended on generated proto stuff too, so I have updated the dependency. PTAL.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 84.749% when pulling bc9a6c4 on garrettjonesgoogle:master into 062600a on GoogleCloudPlatform:master.

@mziccard
Copy link
Contributor

It turns out that datastore depended on generated proto stuff too, so I have updated the dependency. PTAL.

Yes this was discussed here.

Non related to this PR: I noticed that in all VeneerToolkit pom.xml there's the auto-value dependency, is it really needed?

<dependency>
  <groupId>com.google.auto.value</groupId>
  <artifactId>auto-value</artifactId>
  <version>1.1</version>
</dependency>

@garrettjonesgoogle
Copy link
Member Author

It looks like it wasn't needed; it got added once, and then stayed for the ride. I have removed it now.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 84.744% when pulling bb52fa0 on garrettjonesgoogle:master into 947f03e on GoogleCloudPlatform:master.

@garrettjonesgoogle
Copy link
Member Author

I think this is ready to merge - all tests pass.

@mziccard
Copy link
Contributor

Was the latest merge commit necessary (bb52fa0)?

I have a bunch of PRs to merge, this will be the next one.

@garrettjonesgoogle
Copy link
Member Author

It was not strictly necessary; I was just making sure this PR was up to date. Does it cause a problem?

@mziccard
Copy link
Contributor

It was not strictly necessary; I was just making sure this PR was up to date. Does it cause a problem?

I would not say it causes problems but if I merge this PR using a merge commit that merge commit will remain in the history of master and its unnecessary, if I squash the commits in this PR I get rid of that commit but I also lose the history (which I would prefer not to).

@garrettjonesgoogle
Copy link
Member Author

I see. For googleapis/, we have been doing squash commits to master in order to have a more concise history instead of including every update in each PR, so this merge was more appropriate for that model. I could rebase and force push to the PR so that the merge disappears, if you would like (just let me know).

@mziccard
Copy link
Contributor

I see now that all major changes are in one commit (the first one). I'll squash commits as history is not so meaningful. In cases like this, however, where we updated many different and unrelated dependencies as well as added tests, I prefer having different commits and keep them in the history. So in case something went wrong you can revert changes at a finer granularity.

@mziccard mziccard added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 26, 2016
@mziccard
Copy link
Contributor

I am adding the don't merge label as this PR causes all gRPC calls to fail with a DEADLINE_EXCEEDED error.

@garrettjonesgoogle
Copy link
Member Author

I have fixed the gRPC call failures. PTAL.

@garrettjonesgoogle
Copy link
Member Author

Do I need to worry about the appveyor failure?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 84.807% when pulling a39c658 on garrettjonesgoogle:master into 947f03e on GoogleCloudPlatform:master.

@mziccard mziccard changed the title Regenerating SPI classes Update grpc, protobuf, datastore and gax dependencies, regenerate SPI classes Sep 28, 2016
@mziccard mziccard removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 28, 2016
@@ -101,22 +101,22 @@
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
<version>3.0.0-beta-3</version>
<version>3.0.0</version>

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@mziccard mziccard merged commit d2470fb into googleapis:master Sep 28, 2016
github-actions bot pushed a commit that referenced this pull request Jul 28, 2022
…1273)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://github.com/googleapis/java-core) | `2.8.1` -> `2.8.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.3/compatibility-slim/2.8.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.3/confidence-slim/2.8.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-core</summary>

### [`v2.8.3`](https://github.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;283-httpsgithubcomgoogleapisjava-corecomparev282v283-2022-07-26)

[Compare Source](https://github.com/googleapis/java-core/compare/v2.8.1...v2.8.3)

##### Dependencies

-   update dependency com.google.api-client:google-api-client-bom to v2 ([#&#8203;868](https://github.com/googleapis/java-core/issues/868)) ([e117c40](https://github.com/googleapis/java-core/commit/e117c40f31acf16a45bdbeeb727ba26d80eb6a51))
-   update dependency com.google.api:gax-bom to v2.18.4 ([#&#8203;864](https://github.com/googleapis/java-core/issues/864)) ([bd40b1d](https://github.com/googleapis/java-core/commit/bd40b1d1b36cdcfa833047609e2488594b112be1))
-   update dependency com.google.api:gax-bom to v2.18.5 ([#&#8203;876](https://github.com/googleapis/java-core/issues/876)) ([d8dc7fb](https://github.com/googleapis/java-core/commit/d8dc7fbdb0d65e493ca4154658c63e80d89ab600))
-   update dependency com.google.api.grpc:proto-google-common-protos to v2.9.2 ([#&#8203;870](https://github.com/googleapis/java-core/issues/870)) ([7e961e9](https://github.com/googleapis/java-core/commit/7e961e945d5e049a1a1bb2592e9c155b5937e33b))
-   update dependency com.google.api.grpc:proto-google-iam-v1 to v1.5.2 ([#&#8203;865](https://github.com/googleapis/java-core/issues/865)) ([fe7b974](https://github.com/googleapis/java-core/commit/fe7b974a0eae82711ca96edf412944309d5d6202))
-   update dependency com.google.auth:google-auth-library-bom to v1.8.1 ([#&#8203;856](https://github.com/googleapis/java-core/issues/856)) ([92df5d3](https://github.com/googleapis/java-core/commit/92df5d3c248214970d38432e8c264d151298d1e6))
-   update dependency com.google.http-client:google-http-client-bom to v1.42.2 ([#&#8203;871](https://github.com/googleapis/java-core/issues/871)) ([1972e8e](https://github.com/googleapis/java-core/commit/1972e8e45e11597e56609aa5fcd44e61958d5857))
-   update dependency com.google.protobuf:protobuf-bom to v3.21.3 ([#&#8203;874](https://github.com/googleapis/java-core/issues/874)) ([1e18977](https://github.com/googleapis/java-core/commit/1e18977820ac766157156fb6246bd318d207971c))
-   update dependency com.google.protobuf:protobuf-bom to v3.21.4 ([#&#8203;877](https://github.com/googleapis/java-core/issues/877)) ([d12fb5e](https://github.com/googleapis/java-core/commit/d12fb5e4eb8aa42015df84abf31f56408c8b64d8))
-   update dependency io.grpc:grpc-bom to v1.48.0 ([#&#8203;873](https://github.com/googleapis/java-core/issues/873)) ([a45b075](https://github.com/googleapis/java-core/commit/a45b075e414049550c51ff0097337e45128fc499))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-asset).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMjcuNCIsInVwZGF0ZWRJblZlciI6IjMyLjEyNy40In0=-->
github-actions bot pushed a commit that referenced this pull request Aug 9, 2022
🤖 I have created a release *beep* *boop*
---


## [3.5.0](googleapis/java-asset@v3.4.2...v3.5.0) (2022-08-09)


### Features

* Remove v1p4beta1 API protos. v1p4beta1 has been deprecated and announced through MSA. This is the cleanup ([ebab5c6](googleapis/java-asset@ebab5c6))


### Dependencies

* update dependency com.google.api.grpc:proto-google-cloud-orgpolicy-v1 to v2.3.0 ([#1257](googleapis/java-asset#1257)) ([c61c0e8](googleapis/java-asset@c61c0e8))
* update dependency com.google.api.grpc:proto-google-cloud-os-config-v1 to v2.5.1 ([#1279](googleapis/java-asset#1279)) ([5995764](googleapis/java-asset@5995764))
* update dependency com.google.api.grpc:proto-google-cloud-pubsub-v1 to v1.102.10 ([#1292](googleapis/java-asset#1292)) ([76f886e](googleapis/java-asset@76f886e))
* update dependency com.google.api.grpc:proto-google-cloud-pubsub-v1 to v1.102.9 ([#1280](googleapis/java-asset#1280)) ([a35d490](googleapis/java-asset@a35d490))
* update dependency com.google.cloud:google-cloud-bigquery to v2.14.0 ([#1272](googleapis/java-asset#1272)) ([60763d4](googleapis/java-asset@60763d4))
* update dependency com.google.cloud:google-cloud-bigquery to v2.14.1 ([#1274](googleapis/java-asset#1274)) ([8b4efa5](googleapis/java-asset@8b4efa5))
* update dependency com.google.cloud:google-cloud-bigquery to v2.14.2 ([#1294](googleapis/java-asset#1294)) ([ff76d3a](googleapis/java-asset@ff76d3a))
* update dependency com.google.cloud:google-cloud-bigquery to v2.14.3 ([#1296](googleapis/java-asset#1296)) ([4c2a6ec](googleapis/java-asset@4c2a6ec))
* update dependency com.google.cloud:google-cloud-core to v2.8.3 ([#1273](googleapis/java-asset#1273)) ([1ad7821](googleapis/java-asset@1ad7821))
* update dependency com.google.cloud:google-cloud-core to v2.8.4 ([#1275](googleapis/java-asset#1275)) ([a45d90c](googleapis/java-asset@a45d90c))
* update dependency com.google.cloud:google-cloud-core to v2.8.5 ([#1276](googleapis/java-asset#1276)) ([985d6e6](googleapis/java-asset@985d6e6))
* update dependency com.google.cloud:google-cloud-core to v2.8.6 ([#1283](googleapis/java-asset#1283)) ([26f527c](googleapis/java-asset@26f527c))
* update dependency com.google.cloud:google-cloud-core to v2.8.7 ([#1285](googleapis/java-asset#1285)) ([fe40190](googleapis/java-asset@fe40190))
* update dependency com.google.cloud:google-cloud-core to v2.8.8 ([#1288](googleapis/java-asset#1288)) ([566e032](googleapis/java-asset@566e032))
* update dependency com.google.cloud:google-cloud-pubsub to v1.120.1 ([#1229](googleapis/java-asset#1229)) ([dcc463c](googleapis/java-asset@dcc463c))
* update dependency com.google.cloud:google-cloud-pubsub to v1.120.10 ([#1293](googleapis/java-asset#1293)) ([d6188ca](googleapis/java-asset@d6188ca))
* update dependency com.google.cloud:google-cloud-pubsub to v1.120.9 ([#1281](googleapis/java-asset#1281)) ([79d5a3c](googleapis/java-asset@79d5a3c))
* update dependency com.google.cloud:google-cloud-resourcemanager to v1.5.0 ([#1261](googleapis/java-asset#1261)) ([1cca78c](googleapis/java-asset@1cca78c))
* update dependency com.google.cloud:google-cloud-resourcemanager to v1.5.2 ([#1287](googleapis/java-asset#1287)) ([a399744](googleapis/java-asset@a399744))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#1277](googleapis/java-asset#1277)) ([7a27f49](googleapis/java-asset@7a27f49))
* update dependency com.google.cloud:google-cloud-storage to v2.10.0 ([#1282](googleapis/java-asset#1282)) ([66ba2ad](googleapis/java-asset@66ba2ad))
* update dependency com.google.cloud:google-cloud-storage to v2.11.0 ([#1286](googleapis/java-asset#1286)) ([4df8988](googleapis/java-asset@4df8988))
* update dependency com.google.cloud:google-cloud-storage to v2.11.1 ([#1291](googleapis/java-asset#1291)) ([3af9102](googleapis/java-asset@3af9102))
* update dependency com.google.cloud:google-cloud-storage to v2.11.2 ([#1295](googleapis/java-asset#1295)) ([693d42b](googleapis/java-asset@693d42b))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Oct 4, 2022
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 477955264

Source-Link: