Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make renovate bot selective to manually approved upgrades from dashboard. #8414

Merged
merged 8 commits into from
Sep 16, 2022

Conversation

ddixit14
Copy link
Contributor

@ddixit14 ddixit14 commented Sep 16, 2022

This PR limits the scope of RenovateBot to only manually approved upgrades.

This PR is to limit the scope of RenovateBot into only java-shared-config and java-shared-dependencies.
@ddixit14 ddixit14 requested a review from suztomo September 16, 2022 15:16
@ddixit14 ddixit14 removed the request for review from suztomo September 16, 2022 15:33
@ddixit14 ddixit14 requested a review from suztomo September 16, 2022 17:04
renovate.json Outdated
"groupName": "OpenCensus packages"
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary space

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary space

This setting will make all updates require manual approval.
@ddixit14 ddixit14 changed the title chore: Make renovate bot updates selective to shared-config and shared-dependencies chore: Make renovate bot updates selective to manually approved upgrades from dashboard. Sep 16, 2022
@meltsufin
Copy link
Member

@ddixit14 @suztomo What is the problem we're solving here?

@ddixit14 ddixit14 changed the title chore: Make renovate bot updates selective to manually approved upgrades from dashboard. chore: Make renovate bot selective to manually approved upgrades from dashboard. Sep 16, 2022
@suztomo
Copy link
Member

suztomo commented Sep 16, 2022

@meltsufin This #8239

RenovateBot pull requests also caused problem here #8340 (comment)

Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary space

renovate.json Outdated
"groupName": "OpenCensus packages"
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary space

@suztomo suztomo merged commit 8336ad1 into main Sep 16, 2022
@suztomo suztomo deleted the ddixit14-patch-2 branch September 16, 2022 19:13
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Oct 4, 2022
… dashboard. (googleapis#8414)

* This setting will make all updates require manual approval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants