Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bazel): [java-datacatalog] Update WORKSPACE files for rules_gapic, gax_java, generator_java versions #8467

Closed
wants to merge 4 commits into from

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Sep 27, 2022

This is to resolve a diff that was discovered in #8448

@suztomo
Copy link
Member

suztomo commented Sep 27, 2022

googleapis/java-datacatalog#795 was merged on May. This monorepo started late August. That PR 794 cannot be the cause of diff.

@lqiu96
Copy link
Contributor Author

lqiu96 commented Sep 27, 2022

googleapis/java-datacatalog#795 was merged on May. This monorepo started late August. That PR 794 cannot be the cause of diff.

I don't think the diff was because of googleapis/java-datacatalog#795 -- It looks like the changes in java-datacatalog#795 was reverted

PR 8340 reverted the changes that went in googleapis/java-datacatalog#795: https://github.com/googleapis/google-cloud-java/pull/8340/files#diff-ebe3de62a47cce7750d33539cd0fec2f5169fe3d14c490b48bdd9c14a08a1b98

This is the diff PR #8340 created for DataCatalogSettings.java java-datacatalog:
image

This is what is in java-datacatalog now:
image

@suztomo
Copy link
Member

suztomo commented Sep 27, 2022

@lqiu96 The java-datacatalog repository hasn't merged googleapis/java-datacatalog#857 (open).

@lqiu96
Copy link
Contributor Author

lqiu96 commented Sep 27, 2022

I see. Ok, I'll leave java-datacatalog files as a known difference then. We'll have to wait for the person on support to merge that PR.

@lqiu96 lqiu96 closed this Sep 27, 2022
@suztomo
Copy link
Member

suztomo commented Sep 27, 2022

I just merged googleapis/java-datacatalog#857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants