-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Code links broken in doc site #1602
Comments
Ahh! Good find.. I think we're going to need a way to generate the correct tag name. Does everyone follow the Otherwise maybe we want to add the tag name to the toc.json file? Thoughts? @quartzmo @dwsupplee, @jdpedrie |
We use a slash separator: |
Ok, well I think it might be easier/safer to just add the tag name to the toc.json? Otherwise we could just add some conditional logic in the app to try and guess it based on the language. |
Tag name in |
We're not going to be able to split |
Configurable sounds best to me as well |
Steps to reproduce
Navigate to a docs page for a release using the new tag notation (
<package>-<version>
). For example:https://googlecloudplatform.github.io/google-cloud-node/#/docs/datastore/0.3.0/datastore
Click any "Source Code" link in the page.
![image](https://cloud.githubusercontent.com/assets/6609430/18619329/68c02246-7dae-11e6-93e1-df29c077ff86.png)
For example:
https://github.com/GoogleCloudPlatform/google-cloud-node/blob/0.3.0/packages/datastore/src/index.js#L305
Result is 404. Correct URL should be:
https://github.com/GoogleCloudPlatform/google-cloud-node/blob/datastore-0.3.0/packages/datastore/src/index.js#L305
This issue is the same as googleapis/google-cloud-ruby#908, reported by @omaray. I am guessing that the fix will involve updating the GoogleCloudPlatform/gcloud-common site.
The text was updated successfully, but these errors were encountered: