Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system test setup instructions out of date? #1982

Closed
ofrobots opened this issue Feb 10, 2017 · 3 comments
Closed

system test setup instructions out of date? #1982

ofrobots opened this issue Feb 10, 2017 · 3 comments
Assignees
Labels
core type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@ofrobots
Copy link
Contributor

ofrobots commented Feb 10, 2017

From https://github.com/GoogleCloudPlatform/google-cloud-node/blob/master/.github/CONTRIBUTING.md:

$ gcloud preview datastore create-indexes system-test/data/index.yaml
  1. I think preview can be dropped now.
  2. I cannot find the file system-test/data/index.yaml. I am guessing that this isn't the same as ./packages/vision/system-test/data/index.yaml?
@stephenplusplus
Copy link
Contributor

That file should actually be moved to the packages/datastore/system-test/data/ directory. It looks like it got misplaced when we modularized the repo. PR? :)

@ofrobots
Copy link
Contributor Author

Sure. But even after running the create-indexes, I get the following error with the logging system tests:

  1) Logging sinks should create a sink with a Bucket destination:
     Uncaught Error: The caller does not have permission
      at node_modules/grpc/src/node/src/client.js:434:17

I do have $GCLOUD_TESTS_PROJECT_ID and $GCLOUD_TESTS_KEY set to valid values.

@stephenplusplus
Copy link
Contributor

I think the create indexes command will only relate to the Datastore tests.

For the Logging test, that's a new issue. I can reproduce that as well. That used to happen for me when we were developing it, but it hasn't since. @callmehiphop can you see if you get that error?

@danoscarmike danoscarmike added Status: Acknowledged type: question Request for information or clarification. Not an issue. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. core and removed type: question Request for information or clarification. Not an issue. labels Feb 27, 2017
@lukesneeringer lukesneeringer removed the priority: p2 Moderately-important priority. Fix may not be included in next release. label May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

4 participants