Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create x-goog-api-client header for Translation, BigQuery, and Storage #2222

Closed
bjwatson opened this issue Apr 13, 2017 · 4 comments
Closed
Assignees
Labels
api: bigquery Issues related to the BigQuery API. api: storage Issues related to the Cloud Storage API. api: translate Issues related to the Cloud Translation API. priority: p0 Highest priority. Critical issue. P0 implies highest priority.

Comments

@bjwatson
Copy link

What

We need to add the following HTTP header to methods in the Translation, BigQuery, and Storage client libraries:

x-goog-api-client: "gl-node/{NodeJS version} gccl/{client library version}"

Why

This is most critical for Translation, because we discovered that we have no other way of tracking its usage. While we're at it, let's get this done for BigQuery and Storage, too.

This is P0 because every day this is not done is another day of data that we lose. Plus it will take time for users to upgrade to the versions of the client libraries in which this has been done.

@bjwatson bjwatson added api: bigquery Issues related to the BigQuery API. api: storage Issues related to the Cloud Storage API. api: translate Issues related to the Cloud Translation API. priority: p0 Highest priority. Critical issue. P0 implies highest priority. status: acknowledged labels Apr 13, 2017
@bjwatson
Copy link
Author

@stephenplusplus I think that @lukesneeringer has discussed this with you already. I'm belatedly creating the issue to track its completion. Please note that this is P0.

@lukesneeringer
Copy link
Contributor

@stephenplusplus Confirming: please do this as your next task. Thank you.

@stephenplusplus
Copy link
Contributor

When you see a label rainbow, you know it's serious. PR sent: #2223

@bjwatson
Copy link
Author

Fo' sho'. Thanks Stephen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. api: storage Issues related to the Cloud Storage API. api: translate Issues related to the Cloud Translation API. priority: p0 Highest priority. Critical issue. P0 implies highest priority.
Projects
None yet
Development

No branches or pull requests

3 participants