Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error-reporting: serviceContext not sent with uncaughtException #2297

Closed
DominicKramer opened this issue May 11, 2017 · 2 comments
Closed

error-reporting: serviceContext not sent with uncaughtException #2297

DominicKramer opened this issue May 11, 2017 · 2 comments
Assignees
Labels
api: error-reporting type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@DominicKramer
Copy link
Contributor

Is it possible that this is due to https://github.com/GoogleCloudPlatform/cloud-errors-nodejs/blob/v0.1.x/lib/interfaces/uncaught.js#L56 calling sendError instead of report ?

This issue has been migrated from the cloud-errors-nodejs issue #101.

@DominicKramer DominicKramer added api: error-reporting type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 11, 2017
@ofrobots
Copy link
Contributor

Is this still a problem? We no longer provide a built-in mechanism to handle uncaught exceptions.

@DominicKramer
Copy link
Contributor Author

For completeness, I migrated the issue to this repo before closing it. Yes, the code in this repo requires uncaught exceptions to be manually handled and thus this issue no longer applies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: error-reporting type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants