From 755eb36cf37fba1a0aac5c97222a07ed9a1e089e Mon Sep 17 00:00:00 2001 From: Peter Lamut Date: Fri, 10 Jan 2020 17:57:24 +0000 Subject: [PATCH] fix(resourcemanager): update test assertion and core version pin (#10095) * Adjust request params assertion in test (timeout) * Bump pin for core dependency This is to assure that Connection object from core supports timeouts. --- resource_manager/setup.py | 2 +- resource_manager/tests/unit/test__http.py | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/resource_manager/setup.py b/resource_manager/setup.py index 6cc22b82e864..f207d743e9e5 100644 --- a/resource_manager/setup.py +++ b/resource_manager/setup.py @@ -29,7 +29,7 @@ # 'Development Status :: 5 - Production/Stable' release_status = 'Development Status :: 3 - Alpha' dependencies = [ - "google-cloud-core >= 1.0.3, < 2.0dev", + "google-cloud-core >= 1.1.0, < 2.0dev", ] extras = { } diff --git a/resource_manager/tests/unit/test__http.py b/resource_manager/tests/unit/test__http.py index 619845cb3126..291dab1036cb 100644 --- a/resource_manager/tests/unit/test__http.py +++ b/resource_manager/tests/unit/test__http.py @@ -74,5 +74,9 @@ def test_extra_headers(self): } expected_uri = conn.build_api_url("/rainbow") http.request.assert_called_once_with( - data=req_data, headers=expected_headers, method="GET", url=expected_uri + data=req_data, + headers=expected_headers, + method="GET", + url=expected_uri, + timeout=None, )