Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: Fix IAM policy versions in unit test fixtures #10090

Closed
plamut opened this issue Jan 10, 2020 · 1 comment
Closed

Storage: Fix IAM policy versions in unit test fixtures #10090

plamut opened this issue Jan 10, 2020 · 1 comment
Assignees
@plamut
Labels
api: storage Issues related to the Cloud Storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@plamut
Copy link
Contributor

plamut commented Jan 10, 2020

#9869 added a new check when accessing IAM objects as dictionaries. This results in exceptions when configured VERSION > 1.

The change broke several unit tests in storage, because those use VERSION = 17 in their fixtures. These versions must be adjusted.
@plamut plamut added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jan 10, 2020
@plamut plamut self-assigned this Jan 10, 2020
This was referenced Jan 10, 2020
Merged
Closed
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jan 15, 2020
@plamut
Copy link
Contributor Author

plamut commented Jan 16, 2020

Not reproducible on master anymore, thus closing.

@plamut plamut closed this as completed Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamut plamut

Labels
api: storage Issues related to the Cloud Storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(storage): fix VERSION fixtures in several tests plamut/google-cloud-python
2 participants
@plamut @yoshi-automation