Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception Handling Design #3040

Closed
daspecster opened this issue Feb 17, 2017 · 3 comments
Closed

Exception Handling Design #3040

daspecster opened this issue Feb 17, 2017 · 3 comments
Assignees
Labels
api: core priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@daspecster
Copy link
Contributor

Created from #2936.

@dhermes I wasn't 100% sure if you had this all planned out or not, but if there are pieces to it or design questions we could talk about it here instead of in PRs.

The idea(to the best of my knowledge) is to better handle exceptions between our services that handle multiple transports. There is also a differentiation between exceptions that are raised from the upstream service and just normal transport exceptions.

We should have a clear distinction between service related exceptions and transport related exceptions and manage those consistently across all services.

@dhermes
Copy link
Contributor

dhermes commented Feb 17, 2017

Sure. The only TODO I am aware of is:

  • (At a high-level): Support RPC status codes for the transport exceptions we raise (this should be fine, since the HTTP errors usually/always? contain the RPC status code)

@danoscarmike danoscarmike added priority: p2 Moderately-important priority. Fix may not be included in next release. Status: Acknowledged type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Feb 28, 2017
@tseaver
Copy link
Contributor

tseaver commented Jun 7, 2017

#3444 is the first step towards this: it makes the RPC status code -> exception type mapping available everywhere, hoisting the '_catch_remap_gax_error()helper frombigtable.exceptionstocore.exceptions`.

@lukesneeringer
Copy link
Contributor

Superceded by #3738.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: core priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

5 participants