Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose read-isolation parameters in 'Database.read'/'Database.execute_sql' #3659

Closed
tseaver opened this issue Jul 24, 2017 · 4 comments
Closed
Assignees
Labels
api: spanner Issues related to the Spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tseaver
Copy link
Contributor

tseaver commented Jul 24, 2017

And therefore in Snapshot.read / Snapshot.execute_sql.

And therefore in Session.read / Session.execute_sql

From #3615 (comment)

@tseaver tseaver added api: spanner Issues related to the Spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jul 24, 2017
@vkedia
Copy link

vkedia commented Jul 24, 2017

I dont think Snapshot.read and Snapshot.execute_sql should take in isolation parameters since all reads/queries within a multi use snapshot should use the same isolation. So it will be confusing if users can specify those as a parameters for read/query.
Database.read and Database.execute_sql shouls take in these parameters and pass those to the constructor of snapshot.

@tseaver
Copy link
Contributor Author

tseaver commented Jul 24, 2017

Oops, I mean to say Session.read and Session.execute_sql (because those are the ones called by Database.read / Database.execute_sql.

@lukesneeringer lukesneeringer added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Aug 7, 2017
@vkedia
Copy link

vkedia commented Aug 7, 2017

Any updates on this?

@lukesneeringer lukesneeringer removed the priority: p2 Moderately-important priority. Fix may not be included in next release. label Aug 9, 2017
@tseaver
Copy link
Contributor Author

tseaver commented Aug 10, 2017

#3787 is removing those methods (because #3769).

@tseaver tseaver closed this as completed Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants