Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: Add Connection object to Magics Context #8024

Closed
vimota opened this issue May 17, 2019 · 3 comments
Closed

BigQuery: Add Connection object to Magics Context #8024

vimota opened this issue May 17, 2019 · 3 comments
Assignees
Labels
api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@vimota
Copy link
Contributor

vimota commented May 17, 2019

Is your feature request related to a problem? Please describe.
Our team (Kaggle) supports a Public Datasets BigQuery integration in Kernels (Jupyter Notebooks) using a proxy where we inject our own credentials. We currently expose a PublicBigQueryClient that handles this (https://github.com/Kaggle/docker-python/blob/master/patches/kaggle_gcp.py#L70) but we're unable to support Magics via this mechanism since we need to be able to pass in a Connection object to the client.
Describe the solution you'd like
Being able to set either the client object or the Connection object of the Magic (like Context.set_credentials) would solve this.
Describe alternatives you've considered
We've considered monkeypatching the magics client but that may cause more problems.

@tswast
Copy link
Contributor

tswast commented May 17, 2019

I'd be open to a PR that adds a _connection property to Context.

@tswast tswast added api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels May 17, 2019
@tswast
Copy link
Contributor

tswast commented May 17, 2019

The reason I don't think client would be a good property for Context is that there are many default values on Client that are also present in Context. I gets too confusing to know which to set.

@tswast
Copy link
Contributor

tswast commented May 31, 2019

Fixed by #8192.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants