Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubSub: Add system test for streaming pull using an account with pubsub.subscriber role #9382

Closed
plamut opened this issue Oct 1, 2019 · 2 comments · Fixed by #9507
Closed
Assignees
Labels
api: pubsub Issues related to the Pub/Sub API. testing type: process A process-related concern. May include testing, release, or the like.

Comments

@plamut
Copy link
Contributor

plamut commented Oct 1, 2019

A PubSub regression (#9339) was introduced in the 1.0.1, and fixed in the 1.0.2 release. The fix should be covered by a proper system test.

The test should run a simple streaming pull scenario using a service account that only has the pubsub.subscriber role, and no other additional permissions. This implies creating a service account, and adding it to the Kokoro environment (contact @busunkim96 for more info).

Side question: How to easily share the same account(s) with developers that need/want to run system tests locally?

Resources:

@plamut plamut added testing api: pubsub Issues related to the Pub/Sub API. labels Oct 1, 2019
@tseaver tseaver added the type: process A process-related concern. May include testing, release, or the like. label Oct 1, 2019
@plamut plamut self-assigned this Oct 21, 2019
@busunkim96
Copy link
Contributor

@plamut Will look into getting this added to the Kokoro environment today.

As for sharing the account with external developers, I think we'll have to provide instructions on how to re-create the service account?

@plamut
Copy link
Contributor Author

plamut commented Oct 22, 2019

@busunkim96 Thanks!

Re: service account - one potentially annoying thing here is that the system test suite needs to be run using two different service accounts (this new test specifically needs a service account with more limited permissions).

Manually switching from a "default" service account and another one for this specific test (and back) can prove tedious for the developer, and we should ideally avoid that, if achievable with a reasonable effort. I am thinking of the automatic service account switch at test runtime - is that possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. testing type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants