-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(storage): Upgrading ruby to ruby 3 #27599
Merged
dazuma
merged 4 commits into
googleapis:main
from
shubhangi-google:upgrading_ruby_to_ruby_3
Dec 5, 2024
Merged
chore(storage): Upgrading ruby to ruby 3 #27599
dazuma
merged 4 commits into
googleapis:main
from
shubhangi-google:upgrading_ruby_to_ruby_3
Dec 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhangi-google
changed the title
Upgrading ruby to ruby 3
chore(storage): Upgrading ruby to ruby 3
Nov 13, 2024
product-auto-label
bot
added
the
api: storage
Issues related to the Cloud Storage API.
label
Nov 13, 2024
bajajneha27
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Nov 14, 2024
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Nov 14, 2024
bajajneha27
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my end.
dazuma
requested changes
Nov 21, 2024
bajajneha27
approved these changes
Nov 29, 2024
@dazuma Shivangi has made the changes requested. Can you please take a look? |
dazuma
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
shubhangi-google
added a commit
to shubhangi-google/google-cloud-ruby
that referenced
this pull request
Dec 11, 2024
aandreassa
pushed a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrading ruby version dependency for Google cloud storage
sending this as a minor version release