Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): Upgrading ruby to ruby 3 #27599

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

shubhangi-google
Copy link
Contributor

@shubhangi-google shubhangi-google commented Nov 12, 2024

upgrading ruby version dependency for Google cloud storage
sending this as a minor version release

@shubhangi-google shubhangi-google changed the title Upgrading ruby to ruby 3 chore(storage): Upgrading ruby to ruby 3 Nov 13, 2024
@shubhangi-google shubhangi-google marked this pull request as ready for review November 13, 2024 08:57
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Nov 13, 2024
@bajajneha27 bajajneha27 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2024
Copy link
Contributor

@bajajneha27 bajajneha27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my end.

@bajajneha27
Copy link
Contributor

@dazuma Shivangi has made the changes requested. Can you please take a look?

Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@dazuma dazuma merged commit cd9db88 into googleapis:main Dec 5, 2024
10 of 13 checks passed
shubhangi-google added a commit to shubhangi-google/google-cloud-ruby that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants