-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more CloudEvent JSON examples #247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
grant
commented
Jul 1, 2021
- Adds more example CloudEvent JSON payloads
- Updates catalog with samples
- Keeps CI passing
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
product-auto-label
bot
added
the
api: eventarc
Issues related to the googleapis/google-cloudevents API.
label
Jul 1, 2021
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jul 1, 2021
jskeet
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions, but otherwise fine. Definitely good to get more samples.
testdata/google/events/cloud/scheduler/v1/SchedulerJobData-simple.json
Outdated
Show resolved
Hide resolved
testdata/google/events/cloud/storage/v1/StorageObjectData-complex.json
Outdated
Show resolved
Hide resolved
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jul 2, 2021
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 4, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.5.0](https://www.github.com/googleapis/google-cloudevents/compare/v1.4.0...v1.5.0) (2021-07-04) ### Features * Add more CloudEvent JSON examples ([#247](https://www.github.com/googleapis/google-cloudevents/issues/247)) ([5598512](https://www.github.com/googleapis/google-cloudevents/commit/55985127083e688934ed0d0dbba41664865eb1ed)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: eventarc
Issues related to the googleapis/google-cloudevents API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.