Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'response_callback' argument to 'consume' / 'consume_next_chunk' methods. #113

Closed
tseaver opened this issue Nov 13, 2019 · 1 comment
Closed

Add 'response_callback' argument to 'consume' / 'consume_next_chunk' methods. #113

tseaver opened this issue Nov 13, 2019 · 1 comment
Assignees
@tseaver
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tseaver
Copy link
Contributor

tseaver commented Nov 13, 2019

In support of https://github.com/googleapis/google-cloud-python/issues/9787.

Whether or not the implementation in google-cloud-storage exposes a callback argument, we need to provide it here, to allow either Blob.download_* or its callers access to the response headers.
@tseaver tseaver added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Nov 13, 2019
@tseaver tseaver mentioned this issue Nov 13, 2019
Closed
@tseaver
Copy link
Contributor Author

tseaver commented Jul 23, 2020

@william-silversmith has submitted a PR to python-storage which makes the general-purpose callback strategy unneeded.

@tseaver tseaver closed this as completed Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add 'response_callback' to 'consume' / 'consume_next_chunk'
1 participant
@tseaver