Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add 'x-goog-resumable': 'start' header. #99

Closed
wants to merge 2 commits into from
Closed

WIP: Add 'x-goog-resumable': 'start' header. #99

wants to merge 2 commits into from

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 28, 2019

FBO using ResumableUpload against GCS XML API, which requires that header.

Closes #60.

Reviewers / future self: please hold off merging until @anshulpatel25 confirms that the added header actually fixes the XML API usecase (see my followup on #60).

FBO using 'ResumableUpload' against GCS XML API, which requires that header.

Closes #60.
@tseaver tseaver added upload do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Aug 28, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Aug 29, 2019

Closing, as just adding a single header is not enough to make the ResumableUpload class work. ISTM that supporting resumable uploads for the XML API docs will require a separate class.

@tseaver tseaver closed this Aug 29, 2019
@tseaver tseaver deleted the 60-add-resumable-upload-header-fbo-xml-api branch August 29, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. upload
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support XML API for Resumable Upload
2 participants