Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

feat(v1p4beta1): add v1p4beta1 client #101

Merged
merged 2 commits into from
Mar 12, 2020
Merged

feat(v1p4beta1): add v1p4beta1 client #101

merged 2 commits into from
Mar 12, 2020

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Mar 12, 2020

Adds the v1p4beta1 client

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2020
@chingor13
Copy link
Contributor Author

Note that synth is blocked until the BUILD.bazel rule lands in googleapis/googleapis.

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #101 into master will decrease coverage by 0.70%.
The diff coverage is 68.21%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #101      +/-   ##
============================================
- Coverage     72.47%   71.76%   -0.71%     
- Complexity      179      214      +35     
============================================
  Files            24       30       +6     
  Lines          1297     1555     +258     
  Branches          6        7       +1     
============================================
+ Hits            940     1116     +176     
- Misses          351      432      +81     
- Partials          6        7       +1     
Impacted Files Coverage Δ Complexity Δ
...e/cloud/asset/v1p4beta1/stub/AssetServiceStub.java 20.00% <20.00%> (ø) 1.00 <1.00> (?)
...le/cloud/asset/v1p4beta1/AssetServiceSettings.java 20.58% <20.58%> (ø) 2.00 <2.00> (?)
...ogle/cloud/asset/v1p4beta1/AssetServiceClient.java 40.00% <40.00%> (ø) 7.00 <7.00> (?)
...1p4beta1/stub/GrpcAssetServiceCallableFactory.java 50.00% <50.00%> (ø) 4.00 <4.00> (?)
...asset/v1p4beta1/stub/AssetServiceStubSettings.java 82.45% <82.45%> (ø) 12.00 <12.00> (?)
...oud/asset/v1p4beta1/stub/GrpcAssetServiceStub.java 86.56% <86.56%> (ø) 9.00 <9.00> (?)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2c1699...ce71896. Read the comment docs.

@chingor13
Copy link
Contributor Author

BUILD.bazel file is available

@chingor13 chingor13 marked this pull request as ready for review March 12, 2020 17:51
@chingor13 chingor13 requested a review from a team March 12, 2020 17:51
@chingor13 chingor13 merged commit add366a into master Mar 12, 2020
@chingor13 chingor13 deleted the v1p4beta1 branch March 12, 2020 19:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants