From 56e79918447989a4a44b1117bd2e7e61ce4adbe9 Mon Sep 17 00:00:00 2001 From: Jeff Ching Date: Mon, 12 Oct 2020 09:37:59 -0700 Subject: [PATCH 1/2] chore: add poorly formatted code --- .../java/com/google/cloud/asset/v1/AssetServiceClient.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/google-cloud-asset/src/main/java/com/google/cloud/asset/v1/AssetServiceClient.java b/google-cloud-asset/src/main/java/com/google/cloud/asset/v1/AssetServiceClient.java index eac122de1..418369d1f 100644 --- a/google-cloud-asset/src/main/java/com/google/cloud/asset/v1/AssetServiceClient.java +++ b/google-cloud-asset/src/main/java/com/google/cloud/asset/v1/AssetServiceClient.java @@ -120,7 +120,9 @@ public static final AssetServiceClient create() throws IOException { * Constructs an instance of AssetServiceClient, using the given settings. The channels are * created based on the settings passed in, or defaults for any settings that are not set. */ - public static final AssetServiceClient create(AssetServiceSettings settings) throws IOException { + public static final AssetServiceClient create( + AssetServiceSettings settings + ) throws IOException { return new AssetServiceClient(settings); } @@ -143,6 +145,9 @@ protected AssetServiceClient(AssetServiceSettings settings) throws IOException { this.stub = ((AssetServiceStubSettings) settings.getStubSettings()).createStub(); this.operationsClient = OperationsClient.create(this.stub.getOperationsStub()); } + public static void foo() { + return; + } @BetaApi("A restructuring of stub classes is planned, so this may break in the future") protected AssetServiceClient(AssetServiceStub stub) { From 86b7d389240e2b86812c04fcc9fd48693fe0f95d Mon Sep 17 00:00:00 2001 From: Jeff Ching Date: Tue, 13 Oct 2020 11:31:33 -0700 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: yoshi-code-bot <70984784+yoshi-code-bot@users.noreply.github.com> --- .../java/com/google/cloud/asset/v1/AssetServiceClient.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/google-cloud-asset/src/main/java/com/google/cloud/asset/v1/AssetServiceClient.java b/google-cloud-asset/src/main/java/com/google/cloud/asset/v1/AssetServiceClient.java index 418369d1f..ab1e332b8 100644 --- a/google-cloud-asset/src/main/java/com/google/cloud/asset/v1/AssetServiceClient.java +++ b/google-cloud-asset/src/main/java/com/google/cloud/asset/v1/AssetServiceClient.java @@ -120,9 +120,7 @@ public static final AssetServiceClient create() throws IOException { * Constructs an instance of AssetServiceClient, using the given settings. The channels are * created based on the settings passed in, or defaults for any settings that are not set. */ - public static final AssetServiceClient create( - AssetServiceSettings settings - ) throws IOException { + public static final AssetServiceClient create(AssetServiceSettings settings) throws IOException { return new AssetServiceClient(settings); } @@ -145,6 +143,7 @@ protected AssetServiceClient(AssetServiceSettings settings) throws IOException { this.stub = ((AssetServiceStubSettings) settings.getStubSettings()).createStub(); this.operationsClient = OperationsClient.create(this.stub.getOperationsStub()); } + public static void foo() { return; }