Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose requirepartitionfilter field in table #158

Merged
merged 10 commits into from
Feb 27, 2020
Merged

feat: expose requirepartitionfilter field in table #158

merged 10 commits into from
Feb 27, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Feb 6, 2020

Fixes #156

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 6, 2020
@codecov
Copy link

codecov bot commented Feb 6, 2020 •
edited
Loading

Codecov Report

Merging #158 into master will decrease coverage by 0.08%.
The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #158      +/-   ##
============================================
- Coverage     77.44%   77.36%   -0.09%     
- Complexity     1110     1116       +6     
============================================
  Files            73       73              
  Lines          5932     5950      +18     
  Branches        645      626      -19     
============================================
+ Hits           4594     4603       +9     
- Misses         1013     1019       +6     
- Partials        325      328       +3
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/google/cloud/bigquery/Table.java 76.82% <0%> (-1.93%) 23 <0> (ø)
...main/java/com/google/cloud/bigquery/TableInfo.java 95.03% <88.88%> (+4.89%) 31 <1> (+3) ⬆️
...y/src/main/java/com/google/cloud/bigquery/Acl.java 65.41% <0%> (-4.68%) 13% <0%> (ø)
...src/main/java/com/google/cloud/bigquery/Model.java 62.71% <0%> (-2.21%) 12% <0%> (ø)
...com/google/cloud/bigquery/StandardSQLDataType.java 73.68% <0%> (-1.32%) 7% <0%> (ø)
...m/google/cloud/bigquery/StandardSQLStructType.java 84.61% <0%> (-1.1%) 5% <0%> (ø)
...ogle/cloud/bigquery/WriteChannelConfiguration.java 85.43% <0%> (-0.69%) 44% <0%> (ø)
...ava/com/google/cloud/bigquery/RoutineArgument.java 85.71% <0%> (-0.65%) 5% <0%> (ø)
...om/google/cloud/bigquery/LoadJobConfiguration.java 89.64% <0%> (-0.52%) 52% <0%> (ø)
...google/cloud/bigquery/ExternalTableDefinition.java 56.38% <0%> (-0.46%) 16% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e060aba...feab159. Read the comment docs.

elharo
elharo suggested changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm still not convinced this is OK as there are alternatives that do not break the API.

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/Table.java Outdated Show resolved Hide resolved
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2020
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2020
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2020
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2020
@pmakani pmakani added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 27, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 27, 2020
@codecov
Copy link

codecov bot commented Feb 27, 2020 •
edited
Loading

Codecov Report

Merging #158 into master will decrease coverage by 0.08%.
The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #158      +/-   ##
============================================
- Coverage     77.44%   77.36%   -0.09%     
- Complexity     1110     1116       +6     
============================================
  Files            73       73              
  Lines          5932     5950      +18     
  Branches        645      626      -19     
============================================
+ Hits           4594     4603       +9     
- Misses         1013     1019       +6     
- Partials        325      328       +3
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/google/cloud/bigquery/Table.java 76.82% <0%> (-1.93%) 23 <0> (ø)
...main/java/com/google/cloud/bigquery/TableInfo.java 95.03% <88.88%> (+4.89%) 31 <1> (+3) ⬆️
...y/src/main/java/com/google/cloud/bigquery/Acl.java 65.41% <0%> (-4.68%) 13% <0%> (ø)
...src/main/java/com/google/cloud/bigquery/Model.java 62.71% <0%> (-2.21%) 12% <0%> (ø)
...com/google/cloud/bigquery/StandardSQLDataType.java 73.68% <0%> (-1.32%) 7% <0%> (ø)
...m/google/cloud/bigquery/StandardSQLStructType.java 84.61% <0%> (-1.1%) 5% <0%> (ø)
...ogle/cloud/bigquery/WriteChannelConfiguration.java 85.43% <0%> (-0.69%) 44% <0%> (ø)
...ava/com/google/cloud/bigquery/RoutineArgument.java 85.71% <0%> (-0.65%) 5% <0%> (ø)
...om/google/cloud/bigquery/LoadJobConfiguration.java 89.64% <0%> (-0.52%) 52% <0%> (ø)
...google/cloud/bigquery/ExternalTableDefinition.java 56.38% <0%> (-0.46%) 16% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e060aba...9d669cb. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #158 into master will decrease coverage by 0.08%.
The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #158      +/-   ##
============================================
- Coverage     77.44%   77.36%   -0.09%     
- Complexity     1110     1116       +6     
============================================
  Files            73       73              
  Lines          5932     5950      +18     
  Branches        645      626      -19     
============================================
+ Hits           4594     4603       +9     
- Misses         1013     1019       +6     
- Partials        325      328       +3
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/google/cloud/bigquery/Table.java 76.82% <0%> (-1.93%) 23 <0> (ø)
...main/java/com/google/cloud/bigquery/TableInfo.java 95.03% <88.88%> (+4.89%) 31 <1> (+3) ⬆️
...y/src/main/java/com/google/cloud/bigquery/Acl.java 65.41% <0%> (-4.68%) 13% <0%> (ø)
...src/main/java/com/google/cloud/bigquery/Model.java 62.71% <0%> (-2.21%) 12% <0%> (ø)
...com/google/cloud/bigquery/StandardSQLDataType.java 73.68% <0%> (-1.32%) 7% <0%> (ø)
...m/google/cloud/bigquery/StandardSQLStructType.java 84.61% <0%> (-1.1%) 5% <0%> (ø)
...ogle/cloud/bigquery/WriteChannelConfiguration.java 85.43% <0%> (-0.69%) 44% <0%> (ø)
...ava/com/google/cloud/bigquery/RoutineArgument.java 85.71% <0%> (-0.65%) 5% <0%> (ø)
...om/google/cloud/bigquery/LoadJobConfiguration.java 89.64% <0%> (-0.52%) 52% <0%> (ø)
...google/cloud/bigquery/ExternalTableDefinition.java 56.38% <0%> (-0.46%) 16% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e060aba...feab159. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #158 into master will decrease coverage by 0.08%.
The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #158      +/-   ##
============================================
- Coverage     77.44%   77.36%   -0.09%     
- Complexity     1110     1116       +6     
============================================
  Files            73       73              
  Lines          5932     5950      +18     
  Branches        645      626      -19     
============================================
+ Hits           4594     4603       +9     
- Misses         1013     1019       +6     
- Partials        325      328       +3
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/google/cloud/bigquery/Table.java 76.82% <0%> (-1.93%) 23 <0> (ø)
...main/java/com/google/cloud/bigquery/TableInfo.java 95.03% <88.88%> (+4.89%) 31 <1> (+3) ⬆️
...y/src/main/java/com/google/cloud/bigquery/Acl.java 65.41% <0%> (-4.68%) 13% <0%> (ø)
...src/main/java/com/google/cloud/bigquery/Model.java 62.71% <0%> (-2.21%) 12% <0%> (ø)
...com/google/cloud/bigquery/StandardSQLDataType.java 73.68% <0%> (-1.32%) 7% <0%> (ø)
...m/google/cloud/bigquery/StandardSQLStructType.java 84.61% <0%> (-1.1%) 5% <0%> (ø)
...ogle/cloud/bigquery/WriteChannelConfiguration.java 85.43% <0%> (-0.69%) 44% <0%> (ø)
...ava/com/google/cloud/bigquery/RoutineArgument.java 85.71% <0%> (-0.65%) 5% <0%> (ø)
...om/google/cloud/bigquery/LoadJobConfiguration.java 89.64% <0%> (-0.52%) 52% <0%> (ø)
...google/cloud/bigquery/ExternalTableDefinition.java 56.38% <0%> (-0.46%) 16% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e060aba...9d669cb. Read the comment docs.

3 similar comments
@codecov-io
Copy link

codecov-io commented Feb 27, 2020 •
edited by codecov bot
Loading

Codecov Report

Merging #158 into master will decrease coverage by 0.08%.
The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #158      +/-   ##
============================================
- Coverage     77.44%   77.36%   -0.09%     
- Complexity     1110     1116       +6     
============================================
  Files            73       73              
  Lines          5932     5950      +18     
  Branches        645      626      -19     
============================================
+ Hits           4594     4603       +9     
- Misses         1013     1019       +6     
- Partials        325      328       +3
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/google/cloud/bigquery/Table.java 76.82% <0%> (-1.93%) 23 <0> (ø)
...main/java/com/google/cloud/bigquery/TableInfo.java 95.03% <88.88%> (+4.89%) 31 <1> (+3) ⬆️
...y/src/main/java/com/google/cloud/bigquery/Acl.java 65.41% <0%> (-4.68%) 13% <0%> (ø)
...src/main/java/com/google/cloud/bigquery/Model.java 62.71% <0%> (-2.21%) 12% <0%> (ø)
...com/google/cloud/bigquery/StandardSQLDataType.java 73.68% <0%> (-1.32%) 7% <0%> (ø)
...m/google/cloud/bigquery/StandardSQLStructType.java 84.61% <0%> (-1.1%) 5% <0%> (ø)
...ogle/cloud/bigquery/WriteChannelConfiguration.java 85.43% <0%> (-0.69%) 44% <0%> (ø)
...ava/com/google/cloud/bigquery/RoutineArgument.java 85.71% <0%> (-0.65%) 5% <0%> (ø)
...om/google/cloud/bigquery/LoadJobConfiguration.java 89.64% <0%> (-0.52%) 52% <0%> (ø)
...google/cloud/bigquery/ExternalTableDefinition.java 56.38% <0%> (-0.46%) 16% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e060aba...9d669cb. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #158 into master will decrease coverage by 0.08%.
The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #158      +/-   ##
============================================
- Coverage     77.44%   77.36%   -0.09%     
- Complexity     1110     1116       +6     
============================================
  Files            73       73              
  Lines          5932     5950      +18     
  Branches        645      626      -19     
============================================
+ Hits           4594     4603       +9     
- Misses         1013     1019       +6     
- Partials        325      328       +3
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/google/cloud/bigquery/Table.java 76.82% <0%> (-1.93%) 23 <0> (ø)
...main/java/com/google/cloud/bigquery/TableInfo.java 95.03% <88.88%> (+4.89%) 31 <1> (+3) ⬆️
...y/src/main/java/com/google/cloud/bigquery/Acl.java 65.41% <0%> (-4.68%) 13% <0%> (ø)
...src/main/java/com/google/cloud/bigquery/Model.java 62.71% <0%> (-2.21%) 12% <0%> (ø)
...com/google/cloud/bigquery/StandardSQLDataType.java 73.68% <0%> (-1.32%) 7% <0%> (ø)
...m/google/cloud/bigquery/StandardSQLStructType.java 84.61% <0%> (-1.1%) 5% <0%> (ø)
...ogle/cloud/bigquery/WriteChannelConfiguration.java 85.43% <0%> (-0.69%) 44% <0%> (ø)
...ava/com/google/cloud/bigquery/RoutineArgument.java 85.71% <0%> (-0.65%) 5% <0%> (ø)
...om/google/cloud/bigquery/LoadJobConfiguration.java 89.64% <0%> (-0.52%) 52% <0%> (ø)
...google/cloud/bigquery/ExternalTableDefinition.java 56.38% <0%> (-0.46%) 16% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e060aba...9d669cb. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #158 into master will decrease coverage by 0.08%.
The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #158      +/-   ##
============================================
- Coverage     77.44%   77.36%   -0.09%     
- Complexity     1110     1116       +6     
============================================
  Files            73       73              
  Lines          5932     5950      +18     
  Branches        645      626      -19     
============================================
+ Hits           4594     4603       +9     
- Misses         1013     1019       +6     
- Partials        325      328       +3
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/google/cloud/bigquery/Table.java 76.82% <0%> (-1.93%) 23 <0> (ø)
...main/java/com/google/cloud/bigquery/TableInfo.java 95.03% <88.88%> (+4.89%) 31 <1> (+3) ⬆️
...y/src/main/java/com/google/cloud/bigquery/Acl.java 65.41% <0%> (-4.68%) 13% <0%> (ø)
...src/main/java/com/google/cloud/bigquery/Model.java 62.71% <0%> (-2.21%) 12% <0%> (ø)
...com/google/cloud/bigquery/StandardSQLDataType.java 73.68% <0%> (-1.32%) 7% <0%> (ø)
...m/google/cloud/bigquery/StandardSQLStructType.java 84.61% <0%> (-1.1%) 5% <0%> (ø)
...ogle/cloud/bigquery/WriteChannelConfiguration.java 85.43% <0%> (-0.69%) 44% <0%> (ø)
...ava/com/google/cloud/bigquery/RoutineArgument.java 85.71% <0%> (-0.65%) 5% <0%> (ø)
...om/google/cloud/bigquery/LoadJobConfiguration.java 89.64% <0%> (-0.52%) 52% <0%> (ø)
...google/cloud/bigquery/ExternalTableDefinition.java 56.38% <0%> (-0.46%) 16% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e060aba...9d669cb. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 27, 2020 •
edited
Loading

Codecov Report

Merging #158 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #158      +/-   ##
============================================
- Coverage     77.44%   77.36%   -0.09%     
- Complexity     1110     1116       +6     
============================================
  Files            73       73              
  Lines          5932     5950      +18     
  Branches        645      626      -19     
============================================
+ Hits           4594     4603       +9     
- Misses         1013     1019       +6     
- Partials        325      328       +3
Impacted Files Coverage Δ Complexity Δ
...y/src/main/java/com/google/cloud/bigquery/Acl.java 65.41% <0.00%> (-4.68%) 13.00% <0.00%> (ø%)
...src/main/java/com/google/cloud/bigquery/Model.java 62.71% <0.00%> (-2.21%) 12.00% <0.00%> (ø%)
...com/google/cloud/bigquery/StandardSQLDataType.java 73.68% <0.00%> (-1.32%) 7.00% <0.00%> (ø%)
...m/google/cloud/bigquery/StandardSQLStructType.java 84.61% <0.00%> (-1.10%) 5.00% <0.00%> (ø%)
...ogle/cloud/bigquery/WriteChannelConfiguration.java 85.43% <0.00%> (-0.69%) 44.00% <0.00%> (ø%)
...ava/com/google/cloud/bigquery/RoutineArgument.java 85.71% <0.00%> (-0.65%) 5.00% <0.00%> (ø%)
...om/google/cloud/bigquery/LoadJobConfiguration.java 89.64% <0.00%> (-0.52%) 52.00% <0.00%> (ø%)
...google/cloud/bigquery/ExternalTableDefinition.java 56.38% <0.00%> (-0.46%) 16.00% <0.00%> (ø%)
...va/com/google/cloud/bigquery/StandardSQLField.java 90.47% <0.00%> (-0.44%) 7.00% <0.00%> (ø%)
...java/com/google/cloud/bigquery/ViewDefinition.java 87.09% <0.00%> (-0.41%) 11.00% <0.00%> (ø%)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e060aba...06419fd. Read the comment docs.

stephaniewang526
stephaniewang526 reviewed Feb 27, 2020
View reviewed changes
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/TableInfo.java Outdated
@@ -399,6 +414,14 @@ public BigInteger getNumRows() {
return labels.userMap();
}

/**
* Returns true if a partition filter (that can be used for partition elimination) is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmakani - hey i can't seem to get this right on GH... could you please see to getting the comment here right to be "is required for..."

@stephaniewang526 stephaniewang526 merged commit 3e51ea0 into googleapis:master Feb 27, 2020
@pmakani pmakani deleted the bigquery-156 branch March 3, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

@elharo elharo elharo approved these changes

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bigquery: expose requirePartitionFilter field in Table.
8 participants
@pmakani @codecov-io @shollyman @elharo @stephaniewang526 @googlebot @yoshi-kokoro @athakor