Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate from google-http-client-jackson2 to google-http-client-gson #2471

Merged
merged 6 commits into from
Jan 23, 2023
Merged

feat: migrate from google-http-client-jackson2 to google-http-client-gson #2471

merged 6 commits into from
Jan 23, 2023

Conversation

Neenu1995
Copy link
Contributor

No description provided.

@Neenu1995 Neenu1995 requested a review from a team January 19, 2023 16:28
@Neenu1995 Neenu1995 requested a review from a team as a code owner January 19, 2023 16:28
@Neenu1995 Neenu1995 requested a review from mhaligowski January 19, 2023 16:28
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Jan 19, 2023
@Neenu1995 Neenu1995 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2023
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 19, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2023
@suztomo
Copy link
Member

suztomo commented Jan 19, 2023

OwlBot postprocessor failed:

Reformatting source...
./google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java:error: Imports not contiguous (perhaps a comment separates them?)
./samples/snippets/src/main/java/com/example/bigquery/AuthUserQuery.java:error: Imports not contiguous (perhaps a comment separates them?)
./samples/snippets/src/main/java/com/example/bigquery/AuthUserFlow.java:error: Imports not contiguous (perhaps a comment separates them?)

@Neenu1995 Neenu1995 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 19, 2023
@Neenu1995 Neenu1995 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 19, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 19, 2023
@Neenu1995 Neenu1995 requested review from suztomo and removed request for mhaligowski January 19, 2023 17:29
@Neenu1995 Neenu1995 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 19, 2023
@Neenu1995
Copy link
Contributor Author

This PR is checking compatibility. Can be migrated to Gson without breaking changes.

@Neenu1995 Neenu1995 changed the title chore: test gson compatibility feat: migrate from google-http-client-jackson2 to google-http-client-gson Jan 23, 2023
@Neenu1995 Neenu1995 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 23, 2023
suztomo
suztomo approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No public interface change. Good.

@Neenu1995 Neenu1995 merged commit 09a8382 into main Jan 23, 2023
@Neenu1995 Neenu1995 deleted the jackson-check branch January 23, 2023 19:31
@release-please release-please bot mentioned this pull request Jan 23, 2023
Merged
This was referenced Jan 31, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@suztomo suztomo suztomo approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Neenu1995 @suztomo @shollyman @yoshi-kokoro