Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NPE when reading BigQueryResultSet from empty tables #3627

Merged
merged 2 commits into from
Jan 9, 2025
Merged

fix: NPE when reading BigQueryResultSet from empty tables #3627

merged 2 commits into from
Jan 9, 2025

Conversation

PhongChuong
Copy link
Contributor

@PhongChuong PhongChuong commented Jan 8, 2025 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3626 ☕️

@PhongChuong PhongChuong requested a review from a team as a code owner January 8, 2025 18:28
@PhongChuong PhongChuong requested a review from GaoleMeng January 8, 2025 18:28
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Jan 8, 2025
whuffman36
whuffman36 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@whuffman36 whuffman36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shollyman shollyman removed the request for review from GaoleMeng January 8, 2025 23:10
@PhongChuong PhongChuong merged commit 9a0b05a into main Jan 9, 2025
17 checks passed
@PhongChuong PhongChuong deleted the i3626 branch January 9, 2025 13:56
@release-please release-please bot mentioned this pull request Jan 9, 2025
Merged
This was referenced Jan 21, 2025
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whuffman36 whuffman36 whuffman36 approved these changes

@shollyman shollyman shollyman approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Read API throws NPE for empty tables
3 participants
@PhongChuong @shollyman @whuffman36