-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(samples): add query external bigtable using permanent table #764
docs(samples): add query external bigtable using permanent table #764
Conversation
Hi @billyjacobson -- PTAL as well! Thank you. |
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
=========================================
Coverage 80.41% 80.41%
Complexity 1265 1265
=========================================
Files 79 79
Lines 6530 6530
Branches 742 743 +1
=========================================
Hits 5251 5251
Misses 889 889
Partials 390 390 Continue to review full report at Codecov.
|
samples/snippets/src/main/java/com/example/bigquery/QueryExternalBigtablePerm.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for java-samples
samples/snippets/src/main/java/com/example/bigquery/QueryExternalBigtablePerm.java
Outdated
Show resolved
Hide resolved
// once, and can be reused for multiple requests. | ||
BigQuery bigquery = BigQueryOptions.getDefaultInstance().getService(); | ||
|
||
BigtableColumn name = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comments from #763 regarding example bigtable schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d2cc43b
to
4905230
Compare
@stephaniewang526 PTAL. |
🤖 I have created a release \*beep\* \*boop\* --- ### [1.122.2](https://www.github.com/googleapis/java-bigquery/compare/v1.122.1...v1.122.2) (2020-10-08) ### Bug Fixes * bigquery exception get reason and message ([#788](https://www.github.com/googleapis/java-bigquery/issues/788)) ([d783c3a](https://www.github.com/googleapis/java-bigquery/commit/d783c3a2baf80da2aa48c6be555904bd3c33bb1a)) ### Documentation * **samples:** add query external bigtable using permanent table ([#764](https://www.github.com/googleapis/java-bigquery/issues/764)) ([257edfc](https://www.github.com/googleapis/java-bigquery/commit/257edfc14ef09efc4474eb5aba08ccf4d7c199c0)) * **samples:** add query external bigtable using temp table ([#763](https://www.github.com/googleapis/java-bigquery/issues/763)) ([fed28c7](https://www.github.com/googleapis/java-bigquery/commit/fed28c78ca4b70569d5148e67522b0f39321b306)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
No description provided.