Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(samples): create and query Amazon s3 data using external table #835

Merged
merged 10 commits into from
Oct 21, 2020
Merged

docs(samples): create and query Amazon s3 data using external table #835

merged 10 commits into from
Oct 21, 2020

Conversation

stephaniewang526
Copy link
Contributor

No description provided.

@stephaniewang526 stephaniewang526 requested review from a team and pmakani October 20, 2020 22:05
@google-cla
Copy link

google-cla bot commented Oct 20, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 20, 2020
@stephaniewang526 stephaniewang526 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 20, 2020
@stephaniewang526 stephaniewang526 mentioned this pull request Oct 20, 2020
Closed
@google-cla
Copy link

google-cla bot commented Oct 20, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 20, 2020
@stephaniewang526 stephaniewang526 added cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 20, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 20, 2020
@codecov
Copy link

codecov bot commented Oct 20, 2020 •
edited
Loading

Codecov Report

Merging #835 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #835   +/-   ##
=========================================
  Coverage     80.37%   80.37%           
  Complexity     1268     1268           
=========================================
  Files            79       79           
  Lines          6548     6548           
  Branches        749      749           
=========================================
  Hits           5263     5263           
  Misses          892      892           
  Partials        393      393

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afe3b18...01bccfe. Read the comment docs.

lesv
lesv approved these changes Oct 20, 2020
View reviewed changes
Copy link

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider the questions

samples/snippets/src/main/java/com/example/bigquery/QueryExternalTableAws.java Show resolved Hide resolved
samples/snippets/src/main/java/com/example/bigquery/QueryExternalTableAws.java Outdated
Comment on lines 63 to 65
} catch (BigQueryException | InterruptedException e) {
System.out.println("Query not performed \n" + e.toString());
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be caught? Perhaps just mention them or let them propagate? NOTE - BigQueryException is a RuntimeException and InterruptedException is not.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More important is why might these have been thrown and what should a user really do with them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will catch BigQueryException and not InterruptedException.
Updated!

samples/snippets/src/test/java/com/example/bigquery/CreateExternalTableAwsIT.java Outdated
@@ -120,18 +90,19 @@ public void tearDown() throws IOException {

@Test
public void testCreateExternalTableAws() {
String sourceUri = "s3://cloud-samples-tests/us-states.csv";
String sourceUri = "s3://steph-omni-test-bucket/us-states.csv";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might not be your best final choice for a bucket name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - you're right. Created a new bucket for devrel sampels testing. Thank you!

@google-cla
Copy link

google-cla bot commented Oct 20, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 20, 2020
@stephaniewang526 stephaniewang526 removed the cla: no This human has *not* signed the Contributor License Agreement. label Oct 20, 2020
@stephaniewang526 stephaniewang526 added the cla: yes This human has signed the Contributor License Agreement. label Oct 20, 2020
@stephaniewang526 stephaniewang526 merged commit 53a56be into googleapis:master Oct 21, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 23, 2020
@release-please
chore: release 1.123.1 (#838)
7f30c15 
🤖 I have created a release \*beep\* \*boop\* 
---
### [1.123.1](https://www.github.com/googleapis/java-bigquery/compare/v1.123.0...v1.123.1) (2020-10-23)


### Dependencies

* update dependency com.google.apis:google-api-services-bigquery to v2-rev20201015-1.30.10 ([#851](https://www.github.com/googleapis/java-bigquery/issues/851)) ([439eea9](https://www.github.com/googleapis/java-bigquery/commit/439eea95390b72e5aa84ddd9c208475074cf821c))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.13.0 ([#834](https://www.github.com/googleapis/java-bigquery/issues/834)) ([16a105b](https://www.github.com/googleapis/java-bigquery/commit/16a105bdcfbe61e78d79743aa216f281cf57040a))


### Documentation

* **samples:** add export query results to Amazon S3 sample and IT ([#853](https://www.github.com/googleapis/java-bigquery/issues/853)) ([5358620](https://www.github.com/googleapis/java-bigquery/commit/53586207c300002f6bbad3d67f4441729b109f8a))
* **samples:** create and query Amazon s3 data using external table ([#835](https://www.github.com/googleapis/java-bigquery/issues/835)) ([53a56be](https://www.github.com/googleapis/java-bigquery/commit/53a56be8b0878edbc4bc5dd67ed63b48c96d3899))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

@pmakani pmakani Awaiting requested review from pmakani

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephaniewang526 @lesv @yoshi-kokoro