fix: shutdown stream connection when timeout exception occurs #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
yirutang
reviewed
Mar 9, 2024
...e/src/test/java/com/google/cloud/bigquery/storage/v1/it/ITBigQueryWriteManualClientTest.java
Outdated
Show resolved
Hide resolved
yirutang
reviewed
Mar 9, 2024
...oud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/ConnectionWorker.java
Outdated
Show resolved
Hide resolved
...oud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/ConnectionWorker.java
Outdated
Show resolved
Hide resolved
agrawal-siddharth
force-pushed
the
useCommonCleanup
branch
from
cf57b8b to
782894e
Compare
product-auto-label
bot
added
size: s
agrawal-siddharth
force-pushed
the
useCommonCleanup
branch
3 times, most recently
from
d62a1d3 to
a96affe
Compare
agrawal-siddharth
force-pushed
the
useCommonCleanup
branch
from
a96affe to
cd0e7e2
Compare
agrawal-siddharth
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
yirutang
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the timeout exception results in the ConnectionWorker's appendLoop terminating, we must perform all shutdown steps that are performed there.