-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wire and expose profiler api to the StreamWirter/JsonStreamWriter #2561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will be added in the next PR
will be added in the next PR
product-auto-label
bot
added
the
api: bigquerystorage
Issues related to the googleapis/java-bigquerystorage API.
label
Jul 16, 2024
GaoleMeng
force-pushed
the
use_profiler
branch
3 times, most recently
from
July 16, 2024 23:04
b4a8c15
to
f863bd1
Compare
yirutang
approved these changes
Jul 16, 2024
GaoleMeng
changed the title
Wire and expose profiler api to the StreamWirter/JsonStreamWriter
feat: wire and expose profiler api to the StreamWirter/JsonStreamWriter
Jul 16, 2024
GaoleMeng
force-pushed
the
use_profiler
branch
9 times, most recently
from
July 17, 2024 20:41
6c87ab9
to
97677f6
Compare
GaoleMeng
force-pushed
the
use_profiler
branch
4 times, most recently
from
July 17, 2024 21:40
567c3af
to
ab6f8eb
Compare
…age into use_profiler
yifatgortler
pushed a commit
to yifatgortler/java-bigquerystorage
that referenced
this pull request
Jul 25, 2024
…er (googleapis#2561) * Add profiler for request execution details. The usage of the new API will be added in the next PR * Add profiler for request execution details. The usage of the new API will be added in the next PR * add new code change * feat: wire profiler to the actual codebase * .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquerystorage
Issues related to the googleapis/java-bigquerystorage API.
size: l
Pull request size is large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User would be able to call setEnableLatencyProfiler(true) on top of the streamWriter/jsonStreamWriter to understand where is the time spent periodically for the top most latency requests.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.