fix: Remove singleton access to request profiler. Use instance of hook instead. #2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will be added in the next PR
will be added in the next PR
product-auto-label
bot
added
size: l
GaoleMeng
force-pushed
the
profiler_simplify
branch
5 times, most recently
from
db0b27b
to
320492b
Compare
yirutang
approved these changes
Jul 18, 2024
GaoleMeng
force-pushed
the
profiler_simplify
branch
from
320492b
to
0ac8f59
Compare
GaoleMeng
force-pushed
the
profiler_simplify
branch
from
0ac8f59
to
baedafc
Compare
yifatgortler
pushed a commit
to yifatgortler/java-bigquerystorage
that referenced
this pull request
Jul 25, 2024
…k instead. (googleapis#2567) * Add profiler for request execution details. The usage of the new API will be added in the next PR * Add profiler for request execution details. The usage of the new API will be added in the next PR * add new code change * . * Remove directly access to singleton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we could fine grained control which stream writer to collect information
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.