Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding JsonToProtoMessage.java #400

Merged
merged 21 commits into from
Jul 21, 2020
Merged

feat: Adding JsonToProtoMessage.java #400

merged 21 commits into from
Jul 21, 2020

Conversation

allenc3
Copy link
Contributor

@allenc3 allenc3 commented Jul 7, 2020

Added JsonToProtoMessage.java which can convert json data to protocol buffer data given the protocol buffer descriptor.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 7, 2020
@allenc3 allenc3 force-pushed the JsonToProtoMessage branch from 4b83d6a to f337999 Compare July 7, 2020 22:26
@codecov
Copy link

codecov bot commented Jul 7, 2020 •
edited
Loading

Codecov Report

Merging #400 into master will increase coverage by 0.79%.
The diff coverage is 96.96%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #400      +/-   ##
============================================
+ Coverage     77.02%   77.82%   +0.79%     
- Complexity      576      623      +47     
============================================
  Files            55       56       +1     
  Lines          3391     3535     +144     
  Branches        193      234      +41     
============================================
+ Hits           2612     2751     +139     
- Misses          668      677       +9     
+ Partials        111      107       -4
Impacted Files Coverage Δ Complexity Δ
.../bigquery/storage/v1alpha2/JsonToProtoMessage.java 96.96% <96.96%> (ø) 47.00 <47.00> (?)
...ery/storage/v1beta1/BaseBigQueryStorageClient.java 60.34% <0.00%> (-10.25%) 19.00% <0.00%> (ø%)
.../cloud/bigquery/storage/v1alpha2/StreamWriter.java 80.60% <0.00%> (+0.23%) 33.00% <0.00%> (ø%)
...rage/v1beta1/stub/BigQueryStorageStubSettings.java 85.23% <0.00%> (+0.51%) 14.00% <0.00%> (ø%)
...ud/bigquery/storage/v1/BaseBigQueryReadClient.java 43.90% <0.00%> (+2.43%) 10.00% <0.00%> (ø%)
...gquery/storage/v1beta2/BaseBigQueryReadClient.java 43.90% <0.00%> (+2.43%) 10.00% <0.00%> (ø%)
...bigquery/storage/v1alpha2/BigQueryWriteClient.java 58.57% <0.00%> (+5.71%) 28.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90bb713...1065d26. Read the comment docs.

yirutang
yirutang reviewed Jul 9, 2020
View reviewed changes
...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java Outdated Show resolved Hide resolved
...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java Outdated Show resolved Hide resolved
...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java Outdated Show resolved Hide resolved
...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java Outdated Show resolved Hide resolved
...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java Outdated Show resolved Hide resolved
...storage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessageTest.java Outdated Show resolved Hide resolved
...storage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessageTest.java Outdated Show resolved Hide resolved
@allenc3 allenc3 force-pushed the JsonToProtoMessage branch 2 times, most recently from cba9d39 to 3ea5b56 Compare July 13, 2020 16:43
@allenc3 allenc3 force-pushed the JsonToProtoMessage branch from f601561 to a107c68 Compare July 14, 2020 17:27
yirutang
yirutang reviewed Jul 15, 2020
View reviewed changes
...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java Outdated Show resolved Hide resolved
...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java Outdated Show resolved Hide resolved
...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java Outdated Show resolved Hide resolved
...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java Outdated Show resolved Hide resolved
...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java Outdated Show resolved Hide resolved
...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java Outdated Show resolved Hide resolved
Wilson720
Wilson720 reviewed Jul 16, 2020
View reviewed changes
...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java Outdated Show resolved Hide resolved
...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java Show resolved Hide resolved
...storage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessageTest.java Outdated Show resolved Hide resolved
...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java Outdated Show resolved Hide resolved
...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java Outdated Show resolved Hide resolved
...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java Outdated Show resolved Hide resolved
...uerystorage/src/main/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessage.java Show resolved Hide resolved
@allenc3 allenc3 force-pushed the JsonToProtoMessage branch from 4e00901 to 4ffb726 Compare July 16, 2020 22:22
Wilson720
Wilson720 approved these changes Jul 17, 2020
View reviewed changes
Copy link

@Wilson720 Wilson720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

...storage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/JsonToProtoMessageTest.java Outdated Show resolved Hide resolved
allenc3 added 15 commits July 21, 2020 11:37
@allenc3
feat: Finished JsonToProtoMessage, adding in tests
69e4d3c
@allenc3
Added more test cases
d9530a4
@allenc3
Draft version of JsonToProtoMessage
16dd0bb
@allenc3
Fixed float types in jsonTest.proto, and added a test that checks if …
87489a0 
…repeated types are optional
@allenc3
Fix according to PR (added case insensitive feature, added support to…
ce5c045 
… int32 for BQDate)
@allenc3
Update JsonToProtoMessage to fix allowUnknownField behavior
d3d3505
@allenc3
Fix according to PR, used case insensitive treeset for allowUnknownFi…
5c7afe9 
…elds check.
@allenc3
Fixed according to PR
e552748
@allenc3
Fix test errors
1ae4ece
@allenc3
Change loopiing all proto fields to looping all json fields since # o…
cd3d5bf 
…f json fields <= # of proto fields
@allenc3
Remove unuse variable
4804ea9
@allenc3
Remove unuse variable
7f27de6
@allenc3
Removed unnecessary set
46db080
@allenc3
Fixed according to PR, and added proto message empty test case.
df42473
@allenc3
Pushed for loop to be outside of the try catches to remove unnecessar…
155e5ff 
…y for loops.
allenc3 added 3 commits July 21, 2020 11:37
@allenc3
Made tests based on self created protos
2d564a0
@allenc3
Fix jsonTest.proto
426b7fd
@allenc3
Changed throwing empty JsonException to checking for the type of the …
5a7c6b4 
…values first. This prevents catching unexpected JsonExceptions and blocking the actual error message.
@allenc3 allenc3 force-pushed the JsonToProtoMessage branch from ece766a to 5a7c6b4 Compare July 21, 2020 16:38
@allenc3 allenc3 marked this pull request as ready for review July 21, 2020 17:12
@stephaniewang526 stephaniewang526 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jul 21, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 21, 2020
@stephaniewang526 stephaniewang526 merged commit 200da6d into googleapis:master Jul 21, 2020
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
@BenWhitehead
test: attempt tests up to 3 times (googleapis#400)
5a4fd38 
* test: attempt tests up to 3 times

* chore: run formatter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wilson720 Wilson720 Wilson720 approved these changes

@yirutang yirutang yirutang approved these changes

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@allenc3 @stephaniewang526 @yirutang @Wilson720 @googlebot @yoshi-kokoro