Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add JsonWriterCache.java and added JsonWriterCache in DirectWriter to allow JsonWrites #489

Merged
merged 5 commits into from
Aug 16, 2020

Conversation

allenc3
Copy link
Contributor

@allenc3 allenc3 commented Aug 13, 2020

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 13, 2020
@allenc3 allenc3 changed the title feat: add JsonWriterCache.java and added JsonWriterCache in DirectWriter to allow JsonWrites. feat: add JsonWriterCache.java and added JsonWriterCache in DirectWriter to allow JsonWrites Aug 13, 2020
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #489 into master will increase coverage by 0.12%.
The diff coverage is 84.41%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #489      +/-   ##
============================================
+ Coverage     78.30%   78.42%   +0.12%     
- Complexity      642      656      +14     
============================================
  Files            58       59       +1     
  Lines          3687     3764      +77     
  Branches        245      251       +6     
============================================
+ Hits           2887     2952      +65     
- Misses          687      696       +9     
- Partials        113      116       +3     
Impacted Files Coverage Δ Complexity Δ
.../cloud/bigquery/storage/v1alpha2/DirectWriter.java 77.55% <72.22%> (-3.10%) 6.00 <1.00> (+1.00) ⬇️
...oud/bigquery/storage/v1alpha2/JsonWriterCache.java 87.93% <87.93%> (ø) 12.00 <12.00> (?)
...ud/bigquery/storage/v1alpha2/JsonStreamWriter.java 77.39% <100.00%> (+0.19%) 13.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f20fd94...985b186. Read the comment docs.

@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2020
@stephaniewang526 stephaniewang526 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2020
@allenc3 allenc3 marked this pull request as ready for review August 14, 2020 17:29
@stephaniewang526 stephaniewang526 merged commit 34193b8 into googleapis:master Aug 16, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 19, 2020
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
This PR was generated using Autosynth. 🌈


<details><summary>Log from Synthtool</summary>

```
2021-03-04 19:39:21,590 synthtool [DEBUG] > Executing /root/.cache/synthtool/java-storage-nio/.github/readme/synth.py.
On branch autosynth-readme
nothing to commit, working tree clean
2021-03-04 19:39:22,445 synthtool [DEBUG] > Wrote metadata to .github/readme/synth.metadata/synth.metadata.

```
</details>

Full log will be available here:
https://source.cloud.google.com/results/invocations/5faa92eb-f8a8-4b7f-b2b2-0d9a2cd9028b/targets

- [ ] To automatically regenerate this PR, check this box.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants